New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash setting progress after setting dock icon #6091

Merged
merged 3 commits into from Jun 17, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 16, 2016

Add progress indicator whenever the dock tile's content view is empty.

Previously calling setProgressBar after app.dock.setIcon would crash because the subviews array was empty.

This also adds a simple spec to verify the setProgressBar API does not throw which will give some coverage to these APIs for crashes or parameter conversion errors.

Thanks @fasterthanlime for the great investigation.

Closes #6056

@zcbenz zcbenz merged commit 57ed682 into master Jun 17, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3462091 succeeded in 37s
Details
electron-linux-ia32 Build #3462092 succeeded in 34s
Details
electron-linux-x64 Build #3462093 succeeded in 123s
Details
electron-mas-x64 Build #1564 succeeded in 6 min 12 sec
Details
electron-osx-x64 Build #1571 succeeded in 6 min 32 sec
Details
electron-win-ia32 Build #568 succeeded in 6 min 19 sec
Details
electron-win-x64 Build #558 succeeded in 6 min 19 sec
Details

@zcbenz zcbenz deleted the icon-progress-crash branch Jun 17, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 17, 2016

👍

@fasterthanlime

This comment has been minimized.

Contributor

fasterthanlime commented Jun 17, 2016

Thanks for the timely fix! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment