Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for offscreen rendering #7327

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
4 participants
@gerhardberger
Copy link
Member

gerhardberger commented Sep 23, 2016

This PR fixes the software output device offscreen rendering mode on macOS and adds some additional method calls for resize to work properly in offscreen mode.

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Sep 23, 2016

Thanks @gerhardberger. Does this change merit some updates to the documentation as well?

@gerhardberger

This comment has been minimized.

Copy link
Member Author

gerhardberger commented Sep 23, 2016

@zeke no, these are just internal fixes, but it's worth noting that the software output device in offscreen mode since the Chromium53 refactor (v1.4.0) doesn't work on macOS, so people who want to use it have to wait until this change is merged and released or use an earlier version.

@danburzo

This comment has been minimized.

Copy link
Contributor

danburzo commented Sep 27, 2016

#7350 is also dependent on this pull request being merged.

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Sep 27, 2016

👍

@zcbenz zcbenz merged commit 6047001 into electron:master Sep 27, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.