Small fixes for offscreen rendering#7327
Merged
zcbenz merged 1 commit intoelectron:masterfrom Sep 27, 2016
Merged
Conversation
Contributor
|
Thanks @gerhardberger. Does this change merit some updates to the documentation as well? |
Contributor
Author
|
@zeke no, these are just internal fixes, but it's worth noting that the software output device in offscreen mode since the Chromium53 refactor ( |
Contributor
|
#7350 is also dependent on this pull request being merged. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the software output device offscreen rendering mode on macOS and adds some additional method calls for resize to work properly in offscreen mode.