Small fixes for offscreen rendering #7327

Merged
merged 1 commit into from Sep 27, 2016

Projects

None yet

4 participants

@gerhardberger
Member

This PR fixes the software output device offscreen rendering mode on macOS and adds some additional method calls for resize to work properly in offscreen mode.

@gerhardberger gerhardberger fixes software rendering on macos and small resizing addition
ab5e51c
@zeke
Member
zeke commented Sep 23, 2016

Thanks @gerhardberger. Does this change merit some updates to the documentation as well?

@gerhardberger
Member

@zeke no, these are just internal fixes, but it's worth noting that the software output device in offscreen mode since the Chromium53 refactor (v1.4.0) doesn't work on macOS, so people who want to use it have to wait until this change is merged and released or use an earlier version.

@danburzo
Contributor

#7350 is also dependent on this pull request being merged.

@zcbenz
Contributor
zcbenz commented Sep 27, 2016

👍

@zcbenz zcbenz merged commit 6047001 into electron:master Sep 27, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aluxian-huginn aluxian-huginn referenced this pull request in Aluxian/Messenger-for-Desktop Sep 30, 2016
Closed

Update dependency: electron v1.4.2 #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment