feat: upgrade React 16 to 18 #1849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade react/react-dom to ^18.3.1, react-mosaic-component to ^6.1.1, and @testing-library/react to ^16.1.0. Migrate ReactDOM.render() to createRoot(), add Blueprint v3 type augmentations for React 18 compatibility. Remove Enzyme (no React 18 adapter) and delete Enzyme test files — RTL replacements follow in a separate PR. Source changes: - src/renderer/app.tsx: createRoot() migration - src/renderer/components/settings-electron.tsx: fix controlled input - src/renderer/components/output.tsx: null-safe context access - src/blueprint-react18.d.ts: Blueprint children prop augmentations - tests/setup.ts: remove Enzyme config, add crypto.subtle polyfill Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Splitting differently — RTL migration first, React 18 upgrade later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade React from 16.14 to 18.3 (prerequisite for shadcn/ui migration).
Changes
Dependencies
react/react-dom: ^16.14.0 → ^18.3.1react-mosaic-component: ^4.1.1 → ^6.1.1@testing-library/react: ^12.1.5 → ^16.1.0@types/react/@types/react-dom: → ^18.3.0enzyme,enzyme-adapter-react-16,enzyme-to-json,@types/enzyme*Source changes
src/renderer/app.tsx:ReactDOM.render()→createRoot().render()src/renderer/components/settings-electron.tsx: Fix controlled checkbox input (React 18 behavioral change)src/renderer/components/output.tsx: Null-safethis.context?.mosaicActionsaccesssrc/blueprint-react18.d.ts: Type augmentations for Blueprint v3childrenprop compatibilityTest infrastructure
tests/setup.ts: Remove Enzyme config, addcrypto.subtlepolyfill for jsdomvitest.config.ts: Removeenzyme-to-jsonserializeract(),waitFor(), MobX batching)Enzyme test files
Enzyme has no React 18 adapter, so all 21 Enzyme test files + 18 snapshot files are deleted here. RTL replacements follow in #1850.
Verification
tsc --noEmit: 0 errorsvitest run: 70 files, 658 passedyarn start: builds and launches