build(deps): drop electron-default-menu#1915
Merged
dsanders11 merged 3 commits intomainfrom May 5, 2026
Merged
Conversation
|
coverage: 88.447% (-0.2%) from 88.606% — build/drop-electron-default-menu into main |
ckerr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This inlines the default menu that
electron-default-menuwas providing. We could probably now simplify some of the logic in this file since it's build around inserting menu items in an existing default menu, when we could instead put them in the correct spot from the start. But to keep this PR easy to review, I'm first just inlining the default menu as-is.