fix: fixups to the new main process GitHub token code#1937
Merged
Conversation
distinguish between auth/permission errors and network errors
|
coverage: 88.806% (+0.004%) from 88.802% — fix/github-tokens-in-main-process into main |
dsanders11
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second in a series to move GitHub token + gist management into the main process.
This PR has two fixups:
Previously, we deleted the token when Octokit failed. Now, distinguish between permission errors (delete it) vs network errors (don't delete it)
Use safer file permissions for the safeStorage info when it's saved to disk.