fix: adjust styling to avoid hiding IntelliSense popups#243
Merged
Conversation
felixrieseberg
approved these changes
Jul 30, 2019
Member
felixrieseberg
left a comment
There was a problem hiding this comment.
🤔 I feel like there was probably a reason we added the hidden, but I can't remember. My fault for not leaving a comment somewhere, so let's get this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, some styling leads to the Monaco editor's IntelliSense being hidden if it would overflow the window.
Screenshot:

Fix
I pinpointed the root cause of the problem to
.mosaic-previewin our ownsrc/less/mosaic-vendor.lessfile, which setsoverflow: hidden.Looking at the original vendor styling (link), it seems like they're not setting any
overflowanywhere, so it seems to be on our end.Since this vendor
.lessfile was originally added in PR #14 to improve FPS, I wanted to test if removing the rule would cause a regression in the scrolling FPS:overflow: hiddenThere doesn't seem to be any sort of meaningful regression here, and it seems that removing the rule solves the IntelliSense problem (see video 2).