Skip to content

docs: Added the steps to develop fiddle.#264

Closed
arnitkun wants to merge 2 commits intoelectron:masterfrom
arnitkun:feature/Docs-Added_steps_to_run_fiddle
Closed

docs: Added the steps to develop fiddle.#264
arnitkun wants to merge 2 commits intoelectron:masterfrom
arnitkun:feature/Docs-Added_steps_to_run_fiddle

Conversation

@arnitkun
Copy link
Copy Markdown
Contributor

Added the steps to run fiddle, as mentioned in #259

@malept
Copy link
Copy Markdown
Member

malept commented Oct 11, 2019

Wouldn't the steps be "Download the binary and run"? Installing it from the repo is only if you want to work on Fiddle itself.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 11, 2019

Coverage Status

Coverage remained the same at 94.717% when pulling b754da6 on arnitkun:feature/Docs-Added_steps_to_run_fiddle into 32494c0 on electron:master.

@arnitkun arnitkun changed the title Added the steps to run fiddle. docs: Added the steps to run fiddle. Oct 11, 2019
@arnitkun
Copy link
Copy Markdown
Contributor Author

yes, I was only thinking from the point of view of someone who wants to develop himself, but then he/she should know how to do this.

Adding the instruction for "end-users".

@arnitkun arnitkun changed the title docs: Added the steps to run fiddle. docs: Added the steps to develop fiddle. Oct 11, 2019
@malept
Copy link
Copy Markdown
Member

malept commented Oct 11, 2019

In that case, the "how to download Fiddle to develop on it" instructions should be in a CONTRIBUTING.md file (which I'm kind of surprised that it's not in this repo yet) instead of README.md.

Comment on lines +66 to +69
### Running Fiddle

Download and run the latest binary from the electron [releases page](https://electronjs.org/releases/stable).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, since there's already a Download link after the first paragraph in the README.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, removing this and placing the build instructions in contributing.md.

One quick question, should I put a generic contribution guide or would one/more of the members do it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a contributor's guide is a wonderful idea!

@felixrieseberg
Copy link
Copy Markdown
Member

There hasn't been much movement here in a while, so I'm closing this for now. We could always reopen it!

@arnitkun
Copy link
Copy Markdown
Contributor Author

Yeah, Apologies for that, very busy right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants