feat: stop holding a reference to mainWindow#312
Merged
erickzhao merged 1 commit intoelectron:masterfrom Jan 30, 2020
Merged
Conversation
ckerr
approved these changes
Jan 30, 2020
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
See also related: electron/electron#21957
erickzhao
approved these changes
Jan 30, 2020
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserWindowobjects keep themselves referenced at least as long as the window isn't closed, so there's no need to hold a reference to the main window.