Skip to content

feat(template): replace eslint/prettier with oxc.rs stack#4186

Merged
erickzhao merged 15 commits intonextfrom
tmpl-oxlint-fmg
Apr 17, 2026
Merged

feat(template): replace eslint/prettier with oxc.rs stack#4186
erickzhao merged 15 commits intonextfrom
tmpl-oxlint-fmg

Conversation

@erickzhao
Copy link
Copy Markdown
Member

@erickzhao erickzhao commented Mar 20, 2026

Closes #4170.

I figured we might as well migrate to oxfmt if we're going to use oxlint for the templates and provide both to users.

Note that we previously didn't ship any formatting to users, so this is a nice-to-have.

This PR:

  • swaps out eslint for oxlint in the template initialization code
  • swaps out prettier for oxfmt
  • keeps diff minimal by aligning the .oxfmtrc.json with existing rules
  • copies .oxfmtrc.json from the root of the repo to each template (while deleting ignorePaths)
  • fixes a bug in BaseTemplate initialization where there was no way to remove a line when programatically splicing files (now null return values delete the line)

@github-actions github-actions Bot added the next label Mar 27, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 27, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxfmt@​0.41.0901008996100
Updatedelectron@​39.8.6 ⏵ 41.2.094 +1100100 +198100

View full report

@erickzhao erickzhao marked this pull request as ready for review March 28, 2026 00:08
@erickzhao erickzhao requested a review from a team as a code owner March 28, 2026 00:08
@erickzhao erickzhao changed the title feat(template): replace eslint with oxc.rs feat(template): replace eslint with oxc.rs stack Mar 28, 2026
@erickzhao erickzhao changed the title feat(template): replace eslint with oxc.rs stack feat(template): replace eslint/prettier with oxc.rs stack Mar 28, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 15, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@erickzhao erickzhao marked this pull request as draft April 15, 2026 01:05
@erickzhao erickzhao marked this pull request as ready for review April 15, 2026 04:49
@erickzhao erickzhao requested a review from a team April 17, 2026 19:17
@erickzhao erickzhao enabled auto-merge (squash) April 17, 2026 19:46
@erickzhao erickzhao disabled auto-merge April 17, 2026 19:57
@erickzhao
Copy link
Copy Markdown
Member Author

erickzhao commented Apr 17, 2026

7c4251a applies linting consistently across all non-base templates via a shared writeLintConfig handler!

@erickzhao erickzhao enabled auto-merge (squash) April 17, 2026 22:08
@erickzhao erickzhao merged commit f3519bd into next Apr 17, 2026
12 checks passed
@erickzhao erickzhao deleted the tmpl-oxlint-fmg branch April 17, 2026 22:10
@erickzhao erickzhao mentioned this pull request Apr 21, 2026
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants