Skip to content

ci: fix zizmor audit findings #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 3 commits into from
Apr 3, 2026
Merged

ci: fix zizmor audit findings #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2891f1
ci: fix zizmor audit findings
MarshallOfSound Apr 2, 2026
9aa51f9
ci: address cache-poisoning findings with package-manager-cache: false
MarshallOfSound Apr 2, 2026
4fa25ca
chore: fixup
dsanders11 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ updates:
directory: '/'
schedule:
interval: 'monthly'
cooldown:
default-days: 7
2 changes: 1 addition & 1 deletion .github/workflows/add-to-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
issues:
types:
- opened
pull_request_target:
pull_request_target: # zizmor: ignore[dangerous-triggers]
types:
- opened

Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ on:
push:
branches:
- main
tags:
tags: # zizmor: ignore[cache-poisoning] this isn't used in a release workflow
- v[0-9]+.[0-9]+.[0-9]+*
pull_request:
merge_group:
types: [checks_requested]

permissions: {}

env:
NODE_VERSION: 20.17.0

Expand All @@ -24,7 +26,6 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
Expand All @@ -34,6 +35,8 @@ jobs:

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Install dependencies
run: yarn install --immutable
Expand Down Expand Up @@ -83,7 +86,6 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
Expand All @@ -93,6 +95,8 @@ jobs:

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Install dependencies
run: yarn install --immutable
Expand Down Expand Up @@ -159,7 +163,6 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
Expand All @@ -169,6 +172,8 @@ jobs:

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Install dependencies
run: yarn install --immutable
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ on:
tags:
- v7.**

permissions: {}

jobs:
deploy:
runs-on: ubuntu-latest
permissions:
contents: read
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
steps:
Expand All @@ -23,6 +27,7 @@ jobs:
submodules: true
fetch-depth: 0
token: ${{ steps.generate-token.outputs.token }}
persist-credentials: false

- name: Get short SHA for HEAD
id: get-short-sha
Expand All @@ -32,7 +37,7 @@ jobs:
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: 20.x
cache: yarn
package-manager-cache: false

- name: Build
shell: bash
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,22 @@ on:
branches:
- main

permissions: {}

jobs:
check-release-criteria:
name: Check Release Criteria
runs-on: ubuntu-latest
permissions:
contents: read
outputs:
should_release: ${{ steps.check.outputs.should_release }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 2
persist-credentials: false

- name: Check release criteria
id: check
Expand Down Expand Up @@ -94,11 +99,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.0.1
with:
node-version-file: '.nvmrc'
package-manager-cache: false
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand All @@ -123,4 +131,5 @@ jobs:
- name: Create GitHub release
env:
GH_TOKEN: ${{ fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN }}
run: gh release create "v${{ steps.version.outputs.version }}" --target ${{ github.sha }} --generate-notes --prerelease
STEPS_VERSION_OUTPUTS_VERSION: ${{ steps.version.outputs.version }}
run: gh release create "v${STEPS_VERSION_OUTPUTS_VERSION}" --target ${{ github.sha }} --generate-notes --prerelease
Loading