fix(core): convert absolute file path to file URL in locateElectronExecutable#4214
Merged
fix(core): convert absolute file path to file URL in locateElectronExecutable#4214
locateElectronExecutable#4214Conversation
…xecutable` This prevents the following error when running `electron-forge start` on Windows: ``` Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:' ```
erickzhao
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This prevents the following error when running
electron-forge starton Windows:Testing
yarn spawn-verdaccioto start the Verdaccio local registrycreate-electron-appwith$env:NPM_CONFIG_REGISTRY="http://127.0.0.1:4873"; node ./packages/external/create-electron-app/dist/create-electron-app.js vite-esm-test --template=vite-typescriptcd vite-esm-test ; yarn electron-forge start; it should launch the app correctly (on thenextbranch, I get the error mentioned above instead)