fix(cli): detect TTY for interactive mode instead of hardcoding true#4219
Merged
dsanders11 merged 3 commits intoMay 13, 2026
Merged
Conversation
erickzhao
approved these changes
Apr 17, 2026
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
seems legit to me, thanks https://nodejs.org/api/process.html#a-note-on-process-io
erickzhao
changed the title
Member
|
Hey @RobertWHurst, this organization requires you to sign your commits before a PR is mergeable. Do you mind rebasing your PR with signed commits so I can merge? Thanks! |
Contributor
Author
|
absolutely. I'll do that soon. Sorry for the delayed response - busy week. |
Contributor
Author
|
Sorry for the delay. I haven't forgotten, just a busy month - working on a new product release. I'll do so soon. |
ckerr
force-pushed
the
fix/start-interactive-tty-detection
branch
from
d97b4a3 to
83a1674
Compare
RobertWHurst
force-pushed
the
fix/start-interactive-tty-detection
branch
from
83a1674 to
9b9fc8f
Compare
Contributor
Author
|
Signed and verified. Again, sorry for the delay. |
Member
|
sweet, thanks! :) |
georgexu99
approved these changes
May 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
dsanders11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
A very simple change to detect if stdin belongs to a proper tty before enabling interactive mode. This makes running forge in non interactive contexts possible.