Skip to content

feat: add notarization support to MakerPKG#4234

Merged
MarshallOfSound merged 1 commit intonextfrom
claude/pkg-notarization-support-7TDtC
Apr 21, 2026
Merged

feat: add notarization support to MakerPKG#4234
MarshallOfSound merged 1 commit intonextfrom
claude/pkg-notarization-support-7TDtC

Conversation

@MarshallOfSound
Copy link
Copy Markdown
Member

@MarshallOfSound MarshallOfSound commented Apr 21, 2026

Summarize your changes:

This PR adds macOS notarization support to the MakerPKG maker. When both a signing identity and osxNotarize configuration are provided, the generated PKG file will be automatically notarized using the @electron/notarize package.

Changes:

  • Added @electron/notarize dependency to MakerPKG
  • Updated MakerPKG.make() to accept forgeConfig parameter containing packager configuration
  • Implemented conditional notarization logic that runs when:
    • A signing identity is configured in the maker options
    • osxNotarize configuration is present in the forge config
  • Added comprehensive test coverage for notarization scenarios:
    • Notarization occurs when both identity and osxNotarize are configured
    • Notarization is skipped when signing identity is missing
    • Notarization is skipped when osxNotarize configuration is missing
  • Updated existing tests to pass the required forgeConfig parameter

Test Plan:

Added unit tests covering all notarization scenarios. Existing tests pass with the new forgeConfig parameter requirement.

https://claude.ai/code/session_01AUVesVk6mwR9JX2WoKwiEi

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner April 21, 2026 17:30
@github-actions github-actions Bot added the next label Apr 21, 2026
@MarshallOfSound MarshallOfSound changed the title Add notarization support to MakerPKG feat: add notarization support to MakerPKG Apr 21, 2026
@MarshallOfSound MarshallOfSound merged commit 4d49d90 into next Apr 21, 2026
14 of 15 checks passed
@MarshallOfSound MarshallOfSound deleted the claude/pkg-notarization-support-7TDtC branch April 21, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants