Skip to content

docs: Clearly document our backport approval process#249

Merged
jkleinsc merged 3 commits into
masterfrom
backport-feature-approval
Apr 9, 2020
Merged

docs: Clearly document our backport approval process#249
jkleinsc merged 3 commits into
masterfrom
backport-feature-approval

Conversation

@jkleinsc
Copy link
Copy Markdown
Member

This PR updates our documentation on our backport approval process to better line up with our current practices as well as adding the option of approving backports ad-hoc.

@jkleinsc jkleinsc requested a review from a team as a code owner March 13, 2020 21:05
Copy link
Copy Markdown
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the spirit in which the PR was submitted: documenting our current practices. Obviously there are strong opinions on what future practices should be resolving that is for a future PR 🙂

However I would point out that our current practice's point 5 is unenforceable: say a new backport feature causes breakage in an unrelated feature that shares some code paths, so the WG reverts the PR to remove the feature. Removing a feature is a breaking change, so we wouldn't be able to do another release on that major series until the feature was reinstated.

We should also ensure that async emoji-voting has a voting window long enough for everyone in the WG who wants to vote. I'm specifically thinking of the WG members who live or travel outside of CONUS. We wouldn't need to leave voting open if they're not interested; but if they are, they should have their chance

Comment thread wg-releases/README.md Outdated
Comment thread wg-releases/README.md Outdated
Comment thread wg-releases/README.md Outdated
Copy link
Copy Markdown
Contributor

@sofianguy sofianguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkleinsc!

Copy link
Copy Markdown
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkleinsc jkleinsc merged commit 007bd1b into master Apr 9, 2020
@jkleinsc jkleinsc deleted the backport-feature-approval branch April 9, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants