Skip to content

fix: skip npmjs.com links #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix: skip npmjs.com links #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin/lint-markdown-links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ const diagnosticOptions: DiagnosticOptions = {
};

async function fetchExternalLink(link: string, checkRedirects = false) {
const url = new URL(link);
if (url.hostname.endsWith('.npmjs.com')) {
console.log('Skipping npmjs.com link check', link);
return true;
}

try {
const response = await fetch(link, {
headers: {
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/skipped-external-link.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a skipped [external link](https://www.npmjs.com/support)
12 changes: 12 additions & 0 deletions tests/lint-roller-markdown-links.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,18 @@ describe('lint-roller-markdown-links', () => {
expect(status).toEqual(0);
});

it('should skip npmjs.com links', () => {
const { status, stdout } = runLintMarkdownLinks(
'--root',
FIXTURES_DIR,
'skipped-external-link.md',
'--fetch-external-links',
);

expect(status).toEqual(0);
expect(stdout).toContain('Skipping');
});

it('should disallow absolute links by default', () => {
const { status, stdout } = runLintMarkdownLinks(
'--root',
Expand Down