feat!: upgrade to markdownlint-cli@0.40.0 [skip release]

.circleci/config.yml

@@ -20,13 +20,9 @@ workflows:
                 - node/macos
                 - node/windows
               node-version:
+                - '22.1'
                 - '20.10'
                 - '18.18'
-                - '16.20'
-                - '14.21'
-            exclude:
-              - executor: node/macos
-                node-version: '14.21'
       - cfa/release:
           requires:
             - test

configs/markdownlint.json

@@ -1,7 +1,7 @@
 {
   "commands-show-output": false,
   "first-line-h1": false,
-  "header-increment": false,
+  "heading-increment": false,
   "line-length": {
     "code_blocks": false,
     "tables": false,
@@ -10,10 +10,10 @@
   },
   "no-bare-urls": false,
   "no-blanks-blockquote": false,
-  "no-duplicate-header": {
-    "allow_different_nesting": true
+  "no-duplicate-heading": {
+    "siblings_only": true
   },
-  "no-emphasis-as-header": false,
+  "no-emphasis-as-heading": false,
   "no-hard-tabs": {
     "code_blocks": false
   },
@@ -25,5 +25,8 @@
   "single-h1": false,
   "no-inline-html": false,
   "no-angle-brackets": false,
-  "no-curly-braces": false
+  "no-curly-braces": false,
+  "link-image-style": {
+    "shortcut": false
+  }
 }

package.json

@@ -3,7 +3,7 @@
   "version": "0.0.0-development",
   "description": "Markdown linting helpers for Electron org repos",
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=18.0.0"
   },
   "bin": {
     "electron-markdownlint": "./dist/bin/markdownlint-cli-wrapper.js",
@@ -22,8 +22,8 @@
   },
   "scripts": {
     "build": "tsc && yarn run build:emd002 && yarn run build:emd003",
-    "build:emd002": "esbuild --platform=node --target=node14 --format=cjs --bundle --outfile=markdownlint-rules/emd002.js markdownlint-rules/emd002.mjs",
-    "build:emd003": "esbuild --platform=node --target=node14 --format=cjs --bundle --outfile=markdownlint-rules/emd003.js markdownlint-rules/emd003.mjs",
+    "build:emd002": "esbuild --platform=node --target=node18 --format=cjs --bundle --outfile=markdownlint-rules/emd002.js markdownlint-rules/emd002.mjs",
+    "build:emd003": "esbuild --platform=node --target=node18 --format=cjs --bundle --outfile=markdownlint-rules/emd003.js markdownlint-rules/emd003.mjs",
     "prepublishOnly": "yarn run build",
     "lint:eslint": "eslint \"{bin,lib,markdownlint-rules,tests}/**/*.{js,ts}\"",
     "lint:eslint:fix": "eslint --fix \"{bin,lib,markdownlint-rules,tests}/**/*.{js,ts}\"",
@@ -67,7 +67,7 @@
     "balanced-match": "^2.0.0",
     "glob": "^8.1.0",
     "markdown-it": "^13.0.1",
-    "markdownlint-cli": "^0.33.0",
+    "markdownlint-cli": "^0.40.0",
     "mdast-util-from-markdown": "^1.3.0",
     "minimist": "^1.2.8",
     "node-fetch": "^2.6.9",
@@ -85,5 +85,8 @@
     "typescript": {
       "optional": true
     }
+  },
+  "resolutions": {
+    "jackspeak": "2.1.1"
   }
 }

tests/electron-markdownlint.spec.ts

@@ -15,7 +15,7 @@ describe('electron-markdownlint', () => {
       { stdio: 'pipe', encoding: 'utf-8' },
     );
 
-    expect(stderr).toContain('EMD001/no-shortcut-reference-links');
+    expect(stderr).toContain('MD054/link-image-style');
     expect(status).toEqual(1);
   });