Skip to content

Conversation

@kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Oct 14, 2016

This pull request upgrades breakpad to the version that Electron is using.

Previously I was unable to use walkStack on Linux dumps from Electron 1.4.3. They would fail with the following error:

2016-10-12 16:15:05: simple_symbol_supplier.cc:160: ERROR: Can't construct symbol file path without debug_file (code_file = electron)
  • Add linux minidump test
  • Test on Linux
  • Test on Mac

/cc @zcbenz

@zcbenz
Copy link
Contributor

zcbenz commented Oct 18, 2016

👍 Looks good to me.

@kevinsawicki kevinsawicki merged commit d39d90f into master Oct 18, 2016
@kevinsawicki kevinsawicki deleted the upgrade-breakpad branch October 18, 2016 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants