feat: update breakpad #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from the old gyp-built breakpad to the current master.
This is important because the old breakpad can't read newer minidumps produced by current electrons.
I also switched from awkwardly using node-gyp to build something that isn't actually a node module to using the recommend
./configure && makeworkflow in breakpad, and switched from our custom breakpad fork to mainline. The reasons for this:-fno-rttithat node-gyp sets by default).execit.This'll probably make it harder to use on windows, but I'm pretty sure it already didn't work on windows because a) it doesn't try to run
minidump_stackwalk.exeon windows and b) the npm module on unpkg includes a mach-o binary.I also dropped support for
dump_symsbecause apparently it doesn't build on mac any more..?