Skip to content

Conversation

@nornagon
Copy link
Collaborator

@nornagon nornagon commented Jun 26, 2019

This switches from the old gyp-built breakpad to the current master.

This is important because the old breakpad can't read newer minidumps produced by current electrons.

I also switched from awkwardly using node-gyp to build something that isn't actually a node module to using the recommend ./configure && make workflow in breakpad, and switched from our custom breakpad fork to mainline. The reasons for this:

  1. I tried building with node-gyp and ran into several issues (e.g. not being able to override the -fno-rtti that node-gyp sets by default).
  2. breakpad builds with configure && make in its CI: https://chromium.googlesource.com/breakpad/breakpad/+/refs/heads/master/scripts/travis-build.sh#52
  3. It doesn't really make sense to build breakpad as a node addon given we just build an exe and exec it.
  4. Breakpad's gyp files are hilariously broken (like, straight-up missing .cc files), and gyp doesn't even work with xcode 10+.

This'll probably make it harder to use on windows, but I'm pretty sure it already didn't work on windows because a) it doesn't try to run minidump_stackwalk.exe on windows and b) the npm module on unpkg includes a mach-o binary.

I also dropped support for dump_syms because apparently it doesn't build on mac any more..?

@nornagon nornagon changed the title update breakpad chore: update breakpad Jun 26, 2019
@zcbenz
Copy link
Contributor

zcbenz commented Jun 27, 2019

This should probably be a feat instead of chore.

@nornagon nornagon changed the title chore: update breakpad feat: update breakpad Jun 27, 2019
@nornagon
Copy link
Collaborator Author

nornagon commented Jun 27, 2019

I got dump_syms building on linux, but there's still some weirdness going on on macOS. I'm pinging breakpad maintainers to try to figure out what the best way forward is (should we fix the gyp files? or the makefiles? or try to build with chromium's gn files..?)

@nornagon
Copy link
Collaborator Author

nornagon commented Jul 1, 2019

ping on this?

@nornagon nornagon merged commit cc15fce into master Jul 2, 2019
@nornagon nornagon deleted the update-breakpad branch July 29, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants