Skip to content

Conversation

@nornagon
Copy link
Collaborator

Builds off #32.

@nornagon nornagon changed the title add a function for retrieving the module list from a minidump feat: add a function for retrieving the module list from a minidump Jun 28, 2019
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits inline, but overall LGTM.

I hadn't seen binary struct unpacking into JS via Node buffer before. This is disgusting and beautiful. 🙂

@nornagon
Copy link
Collaborator Author

nornagon commented Jul 1, 2019

FWIW if I were going further with this, I'd use something to help keep track of structure sizes. I wanted to avoid adding a dependency, but I've used https://github.com/Keichi/binary-parser in the past with some success. Could potentially add a super-simple version of that as a preamble :)

For now though I'm only adding this because I want to get access to the PDB file names + identifiers, and this was just enough parsing to get those. My next plan is to add code to electron-minidump that downloads the relevant PDBs from microsoft's symbol store.

@nornagon nornagon changed the base branch from update-breakpad to master July 2, 2019 20:47
@nornagon nornagon merged commit e95fa6b into master Jul 2, 2019
@nornagon nornagon deleted the module-list branch July 2, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants