Added SIREN, HSIREN, and Finer with allowed complex inputs #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 14, 2025 14:53
Collaborator
There was a problem hiding this comment.
not going through the actual sine blocks and such, trusting it works.
arthurmccray
approved these changes
Oct 14, 2025
Collaborator
arthurmccray
left a comment
arthurmccray
left a comment
There was a problem hiding this comment.
plz update hsiren or similar channels in/out to be spatial in -> intensity out (and maybe a itty bitty dockstring to explain that) thx.
…t all models have coordinate inputs with intensity as an output for defualt settings; Only tested H-Siren works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SIREN, HSIREN, and Finer models.