-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update vector-im (compound-web to 8.2.1, design tokens is already at 6.0.0 on develop) #30373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bdab4d to
edf2074
Compare
edf2074 to
df6d4c9
Compare
df6d4c9 to
33479a9
Compare
33479a9 to
f2ef835
Compare
f2ef835 to
54f325e
Compare
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from the crypto team here
| const dialog = container.querySelector('[role="dialog"]') as HTMLElement; | ||
| dialog?.focus(); | ||
| await userEvent.keyboard("{Escape}"); | ||
| await userEvent.keyboard("{Escape}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the test is "calls onFinished when Escape is pressed", not "... when Escape is pressed twice", this looks wrong. At the very least it needs some comments to explain it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's a bad merge 🤦♂️. The purpose of one of the other PRS was to fix this. -> https://github.com/element-hq/element-web/pull/30631/files#diff-2cb6b3d0d6c9b34731feb5703b2b78b91e09869f01c92186797cb90abc8a3156R18.
Will correct it.
… couple of lines up explains things.
…6.0.0 on develop) (element-hq#30373) * Update vector-im * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Make BaseDialog's div keyboard focusable and fix test. * Update more e2e tests to use switch instead of checkbox * fix useParticipants incorrectly returning an array when a map is expected * Try again to fix calParticipants * try fix RoomHeader tests again by also mocking useParticipants * Revert "try fix RoomHeader tests again by also mocking useParticipants" This reverts commit f83093c. * Try with no dependencies * try mocking useCall rather than just useParticipantCount * Mock the call store rather than the hook * Only mock the call object for tests that expect it. * Revert "Only mock the call object for tests that expect it." This reverts commit 043d812. * Revert "Mock the call store rather than the hook" This reverts commit 644be31. * Revert "try mocking useCall rather than just useParticipantCount" This reverts commit 92034aa. * Revert "Try with no dependencies" This reverts commit fb502a6. * Reapply "try fix RoomHeader tests again by also mocking useParticipants" This reverts commit e456782. * Revert "try fix RoomHeader tests again by also mocking useParticipants" This reverts commit f83093c. * Revert "Try again to fix calParticipants" This reverts commit c45ad30. * Revert "fix useParticipants incorrectly returning an array when a map is expected" This reverts commit e06d76e. * bump compound-web * Update snapshots * Fix bad merge, we don't need the second call to escape. The comment a couple of lines up explains things. * Trigger build to fix licence/cla check --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: David Langley <davidl@element.io>
This PR contains the following updates:
5.0.1->5.0.28.1.2->8.2.0Release Notes
vector-im/compound-design-tokens (@vector-im/compound-design-tokens)
v5.0.2: Release 5.0.2Compare Source
5.0.2 Release
What's Changed
Full Changelog: element-hq/compound-design-tokens@v5.0.1...v5.0.2
vector-im/compound-web (@vector-im/compound-web)
v8.2.0: Release 8.2.0Compare Source
8.2.0 Release
What's Changed
Full Changelog: element-hq/compound-web@v8.1.2...v8.2.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.