Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jul 22, 2025

This PR contains the following updates:

Package Change Age Confidence
@vector-im/compound-design-tokens 5.0.1 -> 5.0.2 age confidence
@vector-im/compound-web 8.1.2 -> 8.2.0 age confidence

Release Notes

vector-im/compound-design-tokens (@​vector-im/compound-design-tokens)

v5.0.2: Release 5.0.2

Compare Source

5.0.2 Release

What's Changed

Full Changelog: element-hq/compound-design-tokens@v5.0.1...v5.0.2

vector-im/compound-web (@​vector-im/compound-web)

v8.2.0: Release 8.2.0

Compare Source

8.2.0 Release

What's Changed

Full Changelog: element-hq/compound-web@v8.1.2...v8.2.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@renovate
Copy link
Contributor Author

renovate bot commented Aug 5, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@langleyd langleyd marked this pull request as ready for review August 28, 2025 09:21
@langleyd langleyd requested review from a team as code owners August 28, 2025 09:21
@langleyd langleyd requested review from dbkr and richvdh August 28, 2025 09:21
@langleyd langleyd changed the title Update vector-im Update vector-im (compound-web to 8.2.1, design tokens is already at 6.0.0 on develop) Aug 28, 2025
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from the crypto team here

const dialog = container.querySelector('[role="dialog"]') as HTMLElement;
dialog?.focus();
await userEvent.keyboard("{Escape}");
await userEvent.keyboard("{Escape}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the test is "calls onFinished when Escape is pressed", not "... when Escape is pressed twice", this looks wrong. At the very least it needs some comments to explain it.

Copy link
Member

@langleyd langleyd Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a bad merge 🤦‍♂️. The purpose of one of the other PRS was to fix this. -> https://github.com/element-hq/element-web/pull/30631/files#diff-2cb6b3d0d6c9b34731feb5703b2b78b91e09869f01c92186797cb90abc8a3156R18.

Will correct it.

@langleyd langleyd added this pull request to the merge queue Aug 28, 2025
Merged via the queue into develop with commit cf692e7 Aug 28, 2025
35 checks passed
@langleyd langleyd deleted the renovate/vector-im branch August 28, 2025 12:40
Dileep9999 pushed a commit to hemanth-nag/element-web that referenced this pull request Oct 8, 2025
…6.0.0 on develop) (element-hq#30373)

* Update vector-im

* Update snapshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Make BaseDialog's div keyboard focusable and fix test.

* Update more e2e tests to use switch instead of checkbox

* fix useParticipants incorrectly returning an array when a map is expected

* Try again to fix calParticipants

* try fix RoomHeader tests again by also mocking useParticipants

* Revert "try fix RoomHeader tests again by also mocking useParticipants"

This reverts commit f83093c.

* Try with no dependencies

* try mocking useCall rather than just useParticipantCount

* Mock the call store rather than the hook

* Only mock the call object for tests that expect it.

* Revert "Only mock the call object for tests that expect it."

This reverts commit 043d812.

* Revert "Mock the call store rather than the hook"

This reverts commit 644be31.

* Revert "try mocking useCall rather than just useParticipantCount"

This reverts commit 92034aa.

* Revert "Try with no dependencies"

This reverts commit fb502a6.

* Reapply "try fix RoomHeader tests again by also mocking useParticipants"

This reverts commit e456782.

* Revert "try fix RoomHeader tests again by also mocking useParticipants"

This reverts commit f83093c.

* Revert "Try again to fix calParticipants"

This reverts commit c45ad30.

* Revert "fix useParticipants incorrectly returning an array when a map is expected"

This reverts commit e06d76e.

* bump compound-web

* Update snapshots

* Fix bad merge, we don't need the second call to escape. The comment a couple of lines up explains things.

* Trigger build to fix licence/cla check

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: David Langley <davidl@element.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants