Switch to importing matrix-js-sdk properly#33267
Draft
t3chguy wants to merge 4 commits into
Draft
Conversation
Using `src` imports as we did 1. made the build & typechecking slower 2. required us to install certain `@types/` deps which js-sdk needed 3. limited certain options in typescript as we had to support both the typescript features the js-sdk needed as well as element-web (e.g. we couldn't use ESNext lib as js-sdk uses es2024 with some extensions which clash with ESNext)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
srcimports as we did@types/deps which js-sdk neededRequires matrix-org/matrix-js-sdk#5298