Skip to content

Conversation

@jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds an 'ongoing call' indicator to the room list items.

Motivation and context

Finishes #1158

Screenshots / GIFs

Light Dark

Tests

  • Go into a room, start a call.
  • Without hanging up, go back to the room list, the indicator should be present.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner November 13, 2023 10:46
@jmartinesp jmartinesp requested review from julioromano and removed request for a team November 13, 2023 10:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GtWEwG

@codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (14be887) 63.40% compared to head (4abbca5) 63.41%.
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1792      +/-   ##
===========================================
+ Coverage    63.40%   63.41%   +0.01%     
===========================================
  Files         1292     1292              
  Lines        33568    33578      +10     
  Branches      6981     6983       +2     
===========================================
+ Hits         21284    21294      +10     
  Misses        9088     9088              
  Partials      3196     3196              
Files Coverage Δ
...eatures/roomlist/impl/components/RoomSummaryRow.kt 77.77% <100.00%> (+1.20%) ⬆️
...res/roomlist/impl/datasource/RoomListDataSource.kt 85.71% <100.00%> (+0.17%) ⬆️
...eatures/roomlist/impl/model/RoomListRoomSummary.kt 100.00% <100.00%> (ø)
...roomlist/impl/model/RoomListRoomSummaryProvider.kt 100.00% <100.00%> (ø)
...droid/libraries/matrix/api/roomlist/RoomSummary.kt 94.11% <100.00%> (+0.36%) ⬆️
...roid/libraries/mediaplayer/impl/MediaPlayerImpl.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp enabled auto-merge (squash) November 13, 2023 15:29
@jmartinesp jmartinesp merged commit d648f85 into develop Nov 13, 2023
@jmartinesp jmartinesp deleted the feature/jme/roomlist-video-call-indicator branch November 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants