Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Nov 24, 2023

Add tests for:

image

@bmarty bmarty requested a review from a team as a code owner November 24, 2023 09:39
@bmarty bmarty requested review from jmartinesp and removed request for a team November 24, 2023 09:39
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9Rq4TG

@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b620869) 64.64% compared to head (93ec54b) 65.55%.
Report is 5 commits behind head on develop.

Files Patch % Lines
...ervices/toolbox/test/strings/FakeStringProvider.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1878      +/-   ##
===========================================
+ Coverage    64.64%   65.55%   +0.91%     
===========================================
  Files         1318     1319       +1     
  Lines        34362    34323      -39     
  Branches      7117     7106      -11     
===========================================
+ Hits         22213    22501     +288     
+ Misses        8876     8508     -368     
- Partials      3273     3314      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElementBot
Copy link
Collaborator

ElementBot commented Nov 24, 2023

Warnings
⚠️

gradle/libs.versions.toml#L148 - A newer version of org.matrix.rustcomponents:sdk-android than 0.1.68 is available: 0.1.70

Generated by 🚫 dangerJS against 93ec54b

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost +1% coverage in a single PR, great job!

@bmarty bmarty merged commit a2c1476 into develop Nov 24, 2023
@bmarty bmarty deleted the feature/bma/moreTests2 branch November 24, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants