Skip to content

Conversation

@poljar
Copy link
Contributor

@poljar poljar commented Feb 7, 2024

This should help us to track down UTD sources, it ensures that we log the state of a Olm session when we try to decrypt an m.olm.* to-device message.

This should be applied after we update to matrix-org/matrix-rust-sdk#3100.

Matching EX-iOS PR: element-hq/element-x-ios#2427

This should help us to track down UTD sources, it ensures that we log
the state of a Olm session when we try to decrypt an `m.olm.*` to-device
message.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@jmartinesp
Copy link
Member

I'll create a new SDK version then, if those changes are needed.

@poljar
Copy link
Contributor Author

poljar commented Feb 7, 2024

I'll create a new SDK version then, if those changes are needed.

Oh, they aren't strictly needed, but they would be helpful since we otherwise still miss some nice information.

@jmartinesp
Copy link
Member

The Rust SDK version that contains the changes for this PR is in #2359

@poljar
Copy link
Contributor Author

poljar commented Feb 7, 2024

The Rust SDK version that contains the changes for this PR is in #2359

Thanks for taking care of the SDK bump.

@poljar poljar requested a review from a team as a code owner February 8, 2024 08:51
@poljar poljar requested review from ganfra and removed request for a team February 8, 2024 08:51
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (565b2e3) 71.28% compared to head (1fd4075) 71.29%.

❗ Current head 1fd4075 differs from pull request most recent head c864adb. Consider uploading reports for the commit c864adb to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2357   +/-   ##
========================================
  Coverage    71.28%   71.29%           
========================================
  Files         1352     1353    +1     
  Lines        31942    31962   +20     
  Branches      6339     6341    +2     
========================================
+ Hits         22769    22786   +17     
  Misses        5863     5863           
- Partials      3310     3313    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, thanks!

@jmartinesp jmartinesp merged commit 857b94b into element-hq:develop Feb 8, 2024
@poljar poljar deleted the poljar/log-olm-trace branch February 8, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants