-
Notifications
You must be signed in to change notification settings - Fork 359
Reply on redacted and UTD rendering #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…view` (reported by Konsist test)
|
|
||
| @PreviewsDayNight | ||
| @Composable | ||
| internal fun TimelineItemEventRowWithReplyInformativePreview( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split to another preview function, since AS is limiting the number of rendered previews.
| is RoomMembershipContent, | ||
| is StateContent, | ||
| UnknownContent, | ||
| null -> null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to avoid else in when block...
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2384 +/- ##
===========================================
+ Coverage 72.03% 72.09% +0.05%
===========================================
Files 1357 1358 +1
Lines 32021 32084 +63
Branches 6252 6272 +20
===========================================
+ Hits 23067 23131 +64
+ Misses 5703 5699 -4
- Partials 3251 3254 +3 ☔ View full report in Codecov by Sentry. |
|
ganfra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could be great to take the opportunity to show a placeholder while loading the reply?



Type of change
Content
Improve rendering of replied event when this one is redacted or cannot be decrypted
Motivation and context
Closes #2318
Screenshots / GIFs
See recorded ones (and ignore screenshot files renaming...)
Tests
There will be the same rendering with UTD message. To test:
Login to a session and from another client with access to e2e history), reply to an old message in an e2e room.
Tested devices
Checklist