Merged
Conversation
gaelgatelement
force-pushed
the
gaelg/appservice-secrets
branch
from
24a2adf to
3a8589b
Compare
gaelgatelement
force-pushed
the
gaelg/appservice-secrets
branch
from
3a8589b to
ef6327e
Compare
benbz
reviewed
Mar 28, 2025
gaelgatelement
force-pushed
the
gaelg/appservice-secrets
branch
2 times, most recently
from
d7c2e7a to
84600d9
Compare
use common mechanism for configMap or secret
gaelgatelement
force-pushed
the
gaelg/appservice-secrets
branch
from
84600d9 to
129a854
Compare
benbz
reviewed
Mar 28, 2025
gaelgatelement
force-pushed
the
gaelg/appservice-secrets
branch
from
ff02e6f to
0a9ca17
Compare
benbz
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to inject appservices registration from secrets.