MSC4311: invites and knocks should contain the create event#19722
Merged
MadLittleMods merged 2 commits intoelement-hq:developfrom Apr 27, 2026
Merged
MSC4311: invites and knocks should contain the create event#19722MadLittleMods merged 2 commits intoelement-hq:developfrom
MadLittleMods merged 2 commits intoelement-hq:developfrom
Conversation
4 tasks
| config = super().default_config() | ||
| return config | ||
|
|
||
| def test_create_event_present_in_invite_state(self) -> None: |
Contributor
There was a problem hiding this comment.
For reference, it looks like we also have TestMSC4311FullCreateEventOnStrippedState in Complement to cover invite_state. Although that test looks flawed
It looks like that test already passes on develop 🤔 How/why would that be the case?
Contributor
There was a problem hiding this comment.
| ) -> Iterable[tuple[str, str | None]]: | ||
| """Get the event types and state keys to include in the prejoin state.""" | ||
| # MSC4311: the create event must always be included in invite/knock state. | ||
| yield EventTypes.Create, "" |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
With further understanding as I review this, my guess is no (which is fine, something for another PR)
Contributor
Author
There was a problem hiding this comment.
indeed, it doesn't cover including the full m.room.create event PDU
MadLittleMods
approved these changes
Apr 24, 2026
FrenchGithubUser
force-pushed
the
tt/invite-knock-create-event
branch
from
4488101 to
b661661
Compare
Contributor
|
Thanks for another step closer to spec compliance @FrenchGithubUser 🦈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of MSC4311: invites and knocks should contain the create event (stripped state for the client API)
Part of #19414
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.