fix(components): [focus-trap] input selection#10606
Merged
Conversation
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=10606 |
tolking
approved these changes
Nov 18, 2022
Member
|
|
Member
Author
|
@chenxch This doesn't seem to be a problem caused by this change, I will investigate it. 🤔 |
chenxch
reviewed
Nov 20, 2022
Member
|
Should we include @Giwayume for reviewing this? |
Member
Author
That's great, I'd like to hear from Giwayume. |
Collaborator
|
I can't really think of a problem with the PR in its current state. Whether or not the full text is selected or not when focus is returned to an element is more of a question of usability, not really an issue with accessibility. |
chenxch
approved these changes
Dec 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10601
related to #10518, #10384
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.