perf(components): [table] remove redundant updateSelectionByRowKey#21092
Merged
Dsaquel merged 2 commits intoelement-plus:devfrom Jun 22, 2025
Merged
perf(components): [table] remove redundant updateSelectionByRowKey#21092Dsaquel merged 2 commits intoelement-plus:devfrom
updateSelectionByRowKey#21092Dsaquel merged 2 commits intoelement-plus:devfrom
Conversation
|
👋 @OFreshman, seems like this is your first time contribution to element-plus.
|
|
Hello @OFreshman, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
commit: |
|
🧪 Playground Preview: https://element-plus.run/?pr=21092 |
warmthsea
reviewed
Jun 20, 2025
Contributor
Author
|
Hi, kindly pinging for a review when convenient 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.This PR builds upon #20995, which addressed the issue where child nodes in a tree structure could not be selected after toggling pages when
reserve-selectionwas enabled.Since the issue has been resolved by copying the data properly, the
updateSelectionByRowKeyfunction is now redundant. To improve performance and reduce unnecessary computation, this function has been removed.