Skip to content

perf(components): [table] remove redundant updateSelectionByRowKey#21092

Merged
Dsaquel merged 2 commits intoelement-plus:devfrom
OFreshman:perf/table
Jun 22, 2025
Merged

perf(components): [table] remove redundant updateSelectionByRowKey#21092
Dsaquel merged 2 commits intoelement-plus:devfrom
OFreshman:perf/table

Conversation

@OFreshman
Copy link
Copy Markdown
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

This PR builds upon #20995, which addressed the issue where child nodes in a tree structure could not be selected after toggling pages when reserve-selection was enabled.

Since the issue has been resolved by copying the data properly, the updateSelectionByRowKey function is now redundant. To improve performance and reduce unnecessary computation, this function has been removed.

@pull-request-triage
Copy link
Copy Markdown

👋 @OFreshman, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2025

@github-actions
Copy link
Copy Markdown

Hello @OFreshman, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jun 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@21092

commit: f59f22a

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2025

🧪 Playground Preview: https://element-plus.run/?pr=21092
Please comment the example via this playground if needed.

Copy link
Copy Markdown
Member

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OFreshman
Copy link
Copy Markdown
Contributor Author

Hi, kindly pinging for a review when convenient 🙇
Let me know if anything needs to be adjusted.

Copy link
Copy Markdown
Member

@Dsaquel Dsaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Dsaquel Dsaquel enabled auto-merge (squash) June 22, 2025 22:53
@Dsaquel Dsaquel merged commit 23c680f into element-plus:dev Jun 22, 2025
13 checks passed
@element-bot element-bot mentioned this pull request Jul 4, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants