Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated three GitHub Actions workflow files to increase Node.js max old space size from 6144 MB to 8192 MB for the "Build website" step used in documentation builds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
|
Size Change: 0 B Total Size: 1.45 MB ℹ️ View Unchanged
|
Coverage Report
File CoverageNo changed files found. |
|
🧪 Playground Preview: https://element-plus.run/?pr=23850 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/staging-docs.yml:
- Around line 7-9: The job guard that currently checks github.repository_owner
== 'element-plus' must be tightened to block forked PRs from accessing secrets;
update the job-level if condition (the same conditional that gates the Crowdin
steps and deploy steps referencing CROWDIN_TOKEN and EP_BOT_TOKEN) to also
require that either there is no pull_request or the PR head repo is not a fork,
e.g. add a check using github.event.pull_request.head.repo.fork == false (or
combine as: github.event.pull_request == null ||
github.event.pull_request.head.repo.fork == false) alongside the existing
github.repository_owner == 'element-plus' check so fork PRs cannot run the
secret-dependent Crowdin and deploy steps.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7147a48e-ec7a-4861-a8d6-3edc6101a690
📒 Files selected for processing (3)
.github/workflows/publish-docs-deploy-manual.yml.github/workflows/publish-docs-deploy.yml.github/workflows/staging-docs.yml
|
@btea Thanks for your contribution! ❤️ |

Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.#23829 After merging, an out-of-memory error occurs when executing
pnpm docs:build. Currently, increasing themax-old-space-sizeparameter can resolve the issue (it's likely that Prettier is using too much memory when formatting files).https://github.com/element-plus/element-plus/actions/runs/23277552864/job/67683639032
Summary by CodeRabbit