Skip to content

ci: check build fail#23850

Merged
btea merged 4 commits intodevfrom
ci/check-ci-fail
Mar 19, 2026
Merged

ci: check build fail#23850
btea merged 4 commits intodevfrom
ci/check-ci-fail

Conversation

@btea
Copy link
Copy Markdown
Member

@btea btea commented Mar 19, 2026

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

#23829 After merging, an out-of-memory error occurs when executing pnpm docs:build. Currently, increasing the max-old-space-size parameter can resolve the issue (it's likely that Prettier is using too much memory when formatting files).

https://github.com/element-plus/element-plus/actions/runs/23277552864/job/67683639032

Summary by CodeRabbit

  • Chores
    • Increased memory allocation for documentation builds to improve build stability and prevent memory-related failures.
    • Clarified build configuration for documentation pipelines; no functional changes to deployment or build flow.

@btea btea marked this pull request as draft March 19, 2026 06:24
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 761fa47f-7fef-43ca-a8cb-59788027bcb3

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd69f9 and a906518.

📒 Files selected for processing (1)
  • .github/workflows/staging-docs.yml

📝 Walkthrough

Walkthrough

Updated three GitHub Actions workflow files to increase Node.js max old space size from 6144 MB to 8192 MB for the "Build website" step used in documentation builds.

Changes

Cohort / File(s) Summary
Docs workflow memory bump
.github/workflows/publish-docs-deploy-manual.yml, .github/workflows/publish-docs-deploy.yml, .github/workflows/staging-docs.yml
Increased NODE_OPTIONS --max-old-space-size from 6144 to 8192 in the "Build website" step. No other workflow steps, triggers, or inputs changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • rzzf
  • Dsaquel

Poem

🐰 I nibbled logs and found the heap,

Bumped it up so builds can leap,
From six to eight the memory grows,
Docs compile where bright code flows,
A happy hop — the pipeline glows!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'ci: check build fail' is vague and does not clearly describe the actual changes made to the workflows, which are memory limit increases for Node.js. Use a more specific title that clearly indicates the changes, such as 'ci: increase Node.js memory limit for docs build' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the checklist template and references issue #23829 with a brief explanation of the problem and solution, but lacks specific details about which workflows were modified and the exact changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/check-ci-fail
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 19, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus@23850
npm i https://pkg.pr.new/element-plus@23850
yarn add https://pkg.pr.new/element-plus@23850.tgz

commit: a906518

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Size Change: 0 B

Total Size: 1.45 MB

ℹ️ View Unchanged
Filename Size
./dist/element-plus/dist/index.css 46.8 kB
./dist/element-plus/dist/index.full.js 428 kB
./dist/element-plus/dist/index.full.min.js 284 kB
./dist/element-plus/dist/index.full.min.mjs 276 kB
./dist/element-plus/dist/index.full.mjs 419 kB

compressed-size-action

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.56% 18097 / 21150
🔵 Statements 84.35% 18941 / 22455
🔵 Functions 83.44% 4833 / 5792
🔵 Branches 74.04% 10458 / 14123
File CoverageNo changed files found.
Generated in workflow #1959

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

🧪 Playground Preview: https://element-plus.run/?pr=23850
Please comment the example via this playground if needed.

@btea btea force-pushed the ci/check-ci-fail branch from fd44164 to 8e15d77 Compare March 19, 2026 07:30
@btea btea marked this pull request as ready for review March 19, 2026 07:55
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/staging-docs.yml:
- Around line 7-9: The job guard that currently checks github.repository_owner
== 'element-plus' must be tightened to block forked PRs from accessing secrets;
update the job-level if condition (the same conditional that gates the Crowdin
steps and deploy steps referencing CROWDIN_TOKEN and EP_BOT_TOKEN) to also
require that either there is no pull_request or the PR head repo is not a fork,
e.g. add a check using github.event.pull_request.head.repo.fork == false (or
combine as: github.event.pull_request == null ||
github.event.pull_request.head.repo.fork == false) alongside the existing
github.repository_owner == 'element-plus' check so fork PRs cannot run the
secret-dependent Crowdin and deploy steps.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7147a48e-ec7a-4861-a8d6-3edc6101a690

📥 Commits

Reviewing files that changed from the base of the PR and between ebf03ee and 6fd69f9.

📒 Files selected for processing (3)
  • .github/workflows/publish-docs-deploy-manual.yml
  • .github/workflows/publish-docs-deploy.yml
  • .github/workflows/staging-docs.yml

@btea btea enabled auto-merge (squash) March 19, 2026 09:02
@btea btea merged commit 96af4d2 into dev Mar 19, 2026
15 of 16 checks passed
@btea btea deleted the ci/check-ci-fail branch March 19, 2026 09:05
@github-actions
Copy link
Copy Markdown

@btea Thanks for your contribution! ❤️

@element-bot element-bot mentioned this pull request Mar 20, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants