Conversation
…ng meta Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request adds fallback logic to read Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
feat: make override_primary_test_model_id Fusion compatible
Summary
Resolves #929
dbt Fusion does not support arbitrary keys in
config()blocks — custom values must be placed insidemeta. This PR adds a fallback so thatoverride_primary_test_model_idis also read from the unifiedmetadict (which mergesconfig(meta={...})and top-levelmeta) when not found directly inconfig_dict.Precedence:
config_dict→meta(direct config wins).Review & Testing Checklist for Human
orfallback precedence is correct —config_dictvalue takes priority overmeta. If a user sets it in both places, theconfig_dictvalue wins.metaat line 58 (fromget_node_meta) is indeed populated before this line executes (it is — line 58 vs line 91), so no ordering issue.config(meta={'override_primary_test_model_id': 'model.pkg.name'})to confirm the value is picked up correctly.Notes
Summary by CodeRabbit