Conversation
The deprecated_tests directory under integration_tests/ is no longer used by any workflow or referenced anywhere in the codebase. The elementary repo's test-github-action.yml has been updated to use the newer e2e_dbt_project instead. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (16)
📒 Files selected for processing (56)
💤 Files with no reviewable changes (56)
📝 WalkthroughWalkthroughThe pull request removes the entire Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Summary
Removes the entire
integration_tests/deprecated_tests/directory. This test suite is no longer referenced by any workflow or script in this repo or in theelementaryrepo (which previously used it intest-github-action.ymlbut has been updated to usee2e_dbt_projectinstead).The directory contained ~72 files (models, macros, CSV seed data, test runners, snapshots) totaling ~370KB of dead code.
Review & Testing Checklist for Human
integration_tests/deprecated_tests/(e.g. inelementary-internalor other private repos). Grep confirmed zero references withindbt-data-reliabilityandelementary, but other repos were not checked.Notes
test-github-action.ymlto usee2e_dbt_projectinstead of these deprecated tests.Summary by CodeRabbit