Skip to content

Remove deprecated integration tests#947

Merged
haritamar merged 1 commit intomasterfrom
devin/1772355239-remove-deprecated-tests
Mar 1, 2026
Merged

Remove deprecated integration tests#947
haritamar merged 1 commit intomasterfrom
devin/1772355239-remove-deprecated-tests

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 1, 2026

Summary

Removes the entire integration_tests/deprecated_tests/ directory. This test suite is no longer referenced by any workflow or script in this repo or in the elementary repo (which previously used it in test-github-action.yml but has been updated to use e2e_dbt_project instead).

The directory contained ~72 files (models, macros, CSV seed data, test runners, snapshots) totaling ~370KB of dead code.

Review & Testing Checklist for Human

  • Verify no external workflows, scripts, or documentation outside this repo still reference integration_tests/deprecated_tests/ (e.g. in elementary-internal or other private repos). Grep confirmed zero references within dbt-data-reliability and elementary, but other repos were not checked.
  • Confirm there are no other deprecated/dead artifacts that should be cleaned up alongside this removal (e.g. related CI workflow definitions, profile entries, etc.)

Notes

Summary by CodeRabbit

  • Chores
    • Removed deprecated integration test infrastructure, including outdated test configurations, data generation utilities, and test validation macros. This cleanup eliminates legacy test code no longer in use.

The deprecated_tests directory under integration_tests/ is no longer
used by any workflow or referenced anywhere in the codebase. The
elementary repo's test-github-action.yml has been updated to use
the newer e2e_dbt_project instead.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8045ade and acac24e.

⛔ Files ignored due to path filters (16)
  • integration_tests/deprecated_tests/data/training/any_type_column_anomalies_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/backfill_days_column_anomalies_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/dimension_anomalies_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/groups_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/numeric_column_anomalies_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/stats_players_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/stats_team_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/training/string_column_anomalies_training.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/any_type_column_anomalies_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/backfill_days_column_anomalies_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/dimension_anomalies_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/groups_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/numeric_column_anomalies_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/stats_players_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/stats_team_validation.csv is excluded by !**/*.csv
  • integration_tests/deprecated_tests/data/validation/string_column_anomalies_validation.csv is excluded by !**/*.csv
📒 Files selected for processing (56)
  • integration_tests/deprecated_tests/README.md
  • integration_tests/deprecated_tests/dbt_project.yml
  • integration_tests/deprecated_tests/debug.sh
  • integration_tests/deprecated_tests/generate_data.py
  • integration_tests/deprecated_tests/macros/asserts.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/clear_tests.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/test_config_levels.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/tests_validation.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/utils/list_assertions.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/utils/table_assertions.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_backfill_days.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_column_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_config_levels.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_dimensions_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_directional_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_freshness_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_schema_changes.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_seasonal_volume_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_table_anomalies.sql
  • integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_column.sql
  • integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_model.sql
  • integration_tests/deprecated_tests/macros/system/dbg.sql
  • integration_tests/deprecated_tests/macros/system/generate_schema_name.sql
  • integration_tests/deprecated_tests/macros/system/materializations.sql
  • integration_tests/deprecated_tests/macros/system/read_table.sql
  • integration_tests/deprecated_tests/macros/system/return_config_var.sql
  • integration_tests/deprecated_tests/macros/unit_tests/test_adapter_specific_macros_have_default_implementation.sql
  • integration_tests/deprecated_tests/models/any_type_column_anomalies.sql
  • integration_tests/deprecated_tests/models/backfill_days_column_anomalies.sql
  • integration_tests/deprecated_tests/models/config_levels_project.sql
  • integration_tests/deprecated_tests/models/config_levels_test_and_model.sql
  • integration_tests/deprecated_tests/models/copy_numeric_column_anomalies.sql
  • integration_tests/deprecated_tests/models/dimension_anomalies.sql
  • integration_tests/deprecated_tests/models/ephemeral_model.sql
  • integration_tests/deprecated_tests/models/error_model.sql
  • integration_tests/deprecated_tests/models/groups.sql
  • integration_tests/deprecated_tests/models/nested/models/tree/nested.sql
  • integration_tests/deprecated_tests/models/no_timestamp_anomalies.sql
  • integration_tests/deprecated_tests/models/non_dbt_model.sql
  • integration_tests/deprecated_tests/models/numeric_column_anomalies.sql
  • integration_tests/deprecated_tests/models/one.sql
  • integration_tests/deprecated_tests/models/schema.yml
  • integration_tests/deprecated_tests/models/stats_players.sql
  • integration_tests/deprecated_tests/models/stats_team.sql
  • integration_tests/deprecated_tests/models/string_column_anomalies.sql
  • integration_tests/deprecated_tests/models/test_alerts_union.sql
  • integration_tests/deprecated_tests/models/users_per_day_weekly_seasonal.sql
  • integration_tests/deprecated_tests/models/users_per_hour_daily_seasonal.sql
  • integration_tests/deprecated_tests/packages.yml
  • integration_tests/deprecated_tests/run_e2e_tests.py
  • integration_tests/deprecated_tests/run_unit_tests.py
  • integration_tests/deprecated_tests/snapshots/failed_snapshot.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_no_ref.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_one_ref.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_source_ref.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_two_refs.sql
💤 Files with no reviewable changes (56)
  • integration_tests/deprecated_tests/tests/singular_test_with_no_ref.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_schema_changes.sql
  • integration_tests/deprecated_tests/macros/system/generate_schema_name.sql
  • integration_tests/deprecated_tests/macros/system/dbg.sql
  • integration_tests/deprecated_tests/models/nested/models/tree/nested.sql
  • integration_tests/deprecated_tests/macros/asserts.sql
  • integration_tests/deprecated_tests/models/non_dbt_model.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_source_ref.sql
  • integration_tests/deprecated_tests/macros/system/read_table.sql
  • integration_tests/deprecated_tests/macros/unit_tests/test_adapter_specific_macros_have_default_implementation.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_directional_anomalies.sql
  • integration_tests/deprecated_tests/models/stats_team.sql
  • integration_tests/deprecated_tests/models/backfill_days_column_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_freshness_anomalies.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_two_refs.sql
  • integration_tests/deprecated_tests/models/schema.yml
  • integration_tests/deprecated_tests/macros/system/materializations.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/tests_validation.sql
  • integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_model.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_config_levels.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_column_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/utils/list_assertions.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/test_config_levels.sql
  • integration_tests/deprecated_tests/packages.yml
  • integration_tests/deprecated_tests/models/string_column_anomalies.sql
  • integration_tests/deprecated_tests/run_e2e_tests.py
  • integration_tests/deprecated_tests/models/one.sql
  • integration_tests/deprecated_tests/macros/system/return_config_var.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/clear_tests.sql
  • integration_tests/deprecated_tests/models/copy_numeric_column_anomalies.sql
  • integration_tests/deprecated_tests/snapshots/failed_snapshot.sql
  • integration_tests/deprecated_tests/models/users_per_day_weekly_seasonal.sql
  • integration_tests/deprecated_tests/debug.sh
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_backfill_days.sql
  • integration_tests/deprecated_tests/models/error_model.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_dimensions_anomalies.sql
  • integration_tests/deprecated_tests/generate_data.py
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_seasonal_volume_anomalies.sql
  • integration_tests/deprecated_tests/models/stats_players.sql
  • integration_tests/deprecated_tests/models/no_timestamp_anomalies.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/utils/table_assertions.sql
  • integration_tests/deprecated_tests/models/any_type_column_anomalies.sql
  • integration_tests/deprecated_tests/models/config_levels_test_and_model.sql
  • integration_tests/deprecated_tests/models/groups.sql
  • integration_tests/deprecated_tests/run_unit_tests.py
  • integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_column.sql
  • integration_tests/deprecated_tests/macros/e2e_tests/validate_table_anomalies.sql
  • integration_tests/deprecated_tests/README.md
  • integration_tests/deprecated_tests/models/test_alerts_union.sql
  • integration_tests/deprecated_tests/tests/singular_test_with_one_ref.sql
  • integration_tests/deprecated_tests/dbt_project.yml
  • integration_tests/deprecated_tests/models/ephemeral_model.sql
  • integration_tests/deprecated_tests/models/dimension_anomalies.sql
  • integration_tests/deprecated_tests/models/numeric_column_anomalies.sql
  • integration_tests/deprecated_tests/models/config_levels_project.sql
  • integration_tests/deprecated_tests/models/users_per_hour_daily_seasonal.sql

📝 Walkthrough

Walkthrough

The pull request removes the entire integration_tests/deprecated_tests/ directory structure, eliminating obsolete test infrastructure including documentation, configuration, data generation utilities, test orchestration scripts, dbt macros, models, snapshots, and test definitions.

Changes

Cohort / File(s) Summary
Documentation & Configuration
integration_tests/deprecated_tests/README.md, integration_tests/deprecated_tests/dbt_project.yml, integration_tests/deprecated_tests/packages.yml, integration_tests/deprecated_tests/debug.sh
Removed project setup documentation, dbt configuration, dependency declarations, and debug script initialization.
Data Generation
integration_tests/deprecated_tests/generate_data.py
Removed Python script that generated synthetic anomaly test data and CSV files for training and validation datasets.
Test Orchestration Scripts
integration_tests/deprecated_tests/run_e2e_tests.py, integration_tests/deprecated_tests/run_unit_tests.py
Removed CLI-driven test runners for end-to-end and unit tests, including dbt orchestration, result aggregation, and artifact handling logic.
dbt Macros - Assertions
integration_tests/deprecated_tests/macros/asserts.sql, integration_tests/deprecated_tests/macros/e2e_tests/utils/list_assertions.sql, integration_tests/deprecated_tests/macros/e2e_tests/utils/table_assertions.sql
Removed assertion helper macros for value comparison, list operations, and table validation with logging and return codes.
dbt Macros - E2E Test Validation
integration_tests/deprecated_tests/macros/e2e_tests/clear_tests.sql, integration_tests/deprecated_tests/macros/e2e_tests/test_config_levels.sql, integration_tests/deprecated_tests/macros/e2e_tests/tests_validation.sql, integration_tests/deprecated_tests/macros/e2e_tests/validate_*.sql
Removed comprehensive validation macros for schema cleanup, configuration validation, timestamp anomalies, error handling, and anomaly type detection across string, numeric, custom, any-type columns, dimensions, and seasonal data.
dbt Macros - Generic Tests & System
integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_column.sql, integration_tests/deprecated_tests/macros/generic_tests/generic_test_on_model.sql, integration_tests/deprecated_tests/macros/system/*
Removed generic test definitions, schema name generation, materialization handlers, table readers, config variable retrievers, and adapter-specific macro validation utilities.
dbt Models - Data Anomalies
integration_tests/deprecated_tests/models/any_type_column_anomalies.sql, integration_tests/deprecated_tests/models/string_column_anomalies.sql, integration_tests/deprecated_tests/models/numeric_column_anomalies.sql, integration_tests/deprecated_tests/models/backfill_days_column_anomalies.sql, integration_tests/deprecated_tests/models/dimension_anomalies.sql, integration_tests/deprecated_tests/models/no_timestamp_anomalies.sql
Removed dbt models that built synthetic anomaly datasets with training/validation conditional branching for multiple data types.
dbt Models - Seasonal & Grouping
integration_tests/deprecated_tests/models/users_per_hour_daily_seasonal.sql, integration_tests/deprecated_tests/models/users_per_day_weekly_seasonal.sql, integration_tests/deprecated_tests/models/stats_players.sql, integration_tests/deprecated_tests/models/stats_team.sql, integration_tests/deprecated_tests/models/groups.sql
Removed dbt models providing seasonal data and grouping datasets with stage-based conditional logic.
dbt Models - Config & Utility
integration_tests/deprecated_tests/models/config_levels_project.sql, integration_tests/deprecated_tests/models/config_levels_test_and_model.sql, integration_tests/deprecated_tests/models/copy_numeric_column_anomalies.sql, integration_tests/deprecated_tests/models/test_alerts_union.sql, integration_tests/deprecated_tests/models/ephemeral_model.sql, integration_tests/deprecated_tests/models/error_model.sql, integration_tests/deprecated_tests/models/non_dbt_model.sql, integration_tests/deprecated_tests/models/one.sql, integration_tests/deprecated_tests/models/nested/models/tree/nested.sql
Removed utility and test models for configuration validation, alert union composition, and materialization type testing.
dbt Metadata & Tests
integration_tests/deprecated_tests/models/schema.yml, integration_tests/deprecated_tests/snapshots/failed_snapshot.sql, integration_tests/deprecated_tests/tests/singular_test_*.sql
Removed comprehensive test configuration YAML with model definitions and test matrix, snapshot definitions, and singular test queries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

A rabbithole of tests, now sealed away,
Deprecated code bids its final day,
With macros cleared and models gone,
The burrow's cleaner, fresh and strong! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Remove deprecated integration tests' accurately and concisely describes the primary change: the deletion of the entire deprecated_tests directory with its test files, macros, and configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1772355239-remove-deprecated-tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit 8731abd into master Mar 1, 2026
24 checks passed
@haritamar haritamar deleted the devin/1772355239-remove-deprecated-tests branch March 1, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant