Skip to content

Ele 287 override flag#1017

Merged
ellakz merged 17 commits into
masterfrom
ele-287-override-flag
Jul 25, 2023
Merged

Ele 287 override flag#1017
ellakz merged 17 commits into
masterfrom
ele-287-override-flag

Conversation

@ellakz
Copy link
Copy Markdown
Contributor

@ellakz ellakz commented Jul 23, 2023

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Jul 23, 2023

ELE-287 Add "dev" mode for Slack alerts

Is your feature request related to a problem? Please describe.
We want a way to make sure that all slack alerts triggered when running edr monitor on any environment other than production will be sent to a dedicated slack channel, regardless of the channel configuration used in the command or configured in the models/tests/project.

Describe the solution you'd like
Configuration available to set slack channel/s when on dev mode.

Describe alternatives you've considered
We handle it currently by using conditional Jinja in the configuration in dbt yaml files.

@ellakz ellakz requested a review from IDoneShaveIt July 23, 2023 11:43
@github-actions
Copy link
Copy Markdown
Contributor

👋 @ellakz
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Copy link
Copy Markdown
Contributor

@IDoneShaveIt IDoneShaveIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellakz ellakz merged commit 95c3034 into master Jul 25, 2023
@ellakz ellakz deleted the ele-287-override-flag branch July 25, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants