Skip to content

Ele 1706 add to freshness result criteria#1175

Merged
NoyaArie merged 10 commits into
masterfrom
ele-1706-add-result-description-to-source-freshness
Sep 28, 2023
Merged

Ele 1706 add to freshness result criteria#1175
NoyaArie merged 10 commits into
masterfrom
ele-1706-add-result-description-to-source-freshness

Conversation

@NoyaArie
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Sep 26, 2023

ELE-1706 save source freshness criteria field

  • keep the error field - maybe we can support upgrading the cli package only
  • warn_after, error_after, and filter - add to dbt_source_freshness_results

In addition:

  • normalize the status value in the alerts (error = failed, runtime_error = error)

@github-actions
Copy link
Copy Markdown
Contributor

👋 @NoyaArie
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Copy link
Copy Markdown
Contributor

@IDoneShaveIt IDoneShaveIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoyaArie NoyaArie merged commit 1d4ed75 into master Sep 28, 2023
@NoyaArie NoyaArie deleted the ele-1706-add-result-description-to-source-freshness branch September 28, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants