Skip to content

ELE-1790: Renaming, Detection Delay Docs#1197

Merged
dapollak merged 15 commits into
masterfrom
ele-1790-period-param-renaming-finalization-docs
Nov 12, 2023
Merged

ELE-1790: Renaming, Detection Delay Docs#1197
dapollak merged 15 commits into
masterfrom
ele-1790-period-param-renaming-finalization-docs

Conversation

@dapollak
Copy link
Copy Markdown
Contributor

@dapollak dapollak commented Oct 2, 2023

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 2, 2023

👋 @dapollak
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@dapollak dapollak changed the title ELE-1790: Renaming, Detection Delay ELE-1790: Renaming, Detection Delay Docs Oct 2, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Oct 2, 2023

ELE-1790 Period param renaming finalization

Definition of done:

  • Change name - detection period, training period, detection delay
  • Change unit - all will have the option to choose the unit and the count
  • Strong defaults
    • hour
      • detection- 1*bucket
      • training - 48*bucket
    • day
      • detection- 1*bucket
      • training - 14*bucket
    • week
      • detection - 1*bucket
      • training - 7*bucket
    • month
      • detection - 1*bucket
      • training - 7*bucket
  • training set size - this setting will be removed from docs and gradually deprecated because it's conflicting with other settings and is problematic in many ways.

Copy link
Copy Markdown
Contributor

@ellakz ellakz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay- added some comments

Comment thread docs/pics/anomalies/detection-delay.png
Comment thread docs/guides/anomaly-detection-configuration/detection-delay.mdx Outdated
Comment thread docs/guides/anomaly-detection-configuration/detection-delay.mdx
Comment thread docs/guides/anomaly-detection-configuration/training-period.mdx Outdated
@dapollak dapollak requested a review from ellakz November 12, 2023 10:02
Daniel Pollak added 2 commits November 12, 2023 16:11
@dapollak dapollak merged commit 84d2cc5 into master Nov 12, 2023
@dapollak dapollak deleted the ele-1790-period-param-renaming-finalization-docs branch November 12, 2023 15:30
@ellakz ellakz restored the ele-1790-period-param-renaming-finalization-docs branch December 10, 2023 13:36
@ellakz ellakz deleted the ele-1790-period-param-renaming-finalization-docs branch December 10, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants