Ele 1707 add source freshness as test part 2#1208
Merged
Merged
Conversation
ELE-1707 Add source freshness runs as tests in the report
product:
|
Contributor
|
👋 @NoyaArie |
NoyaArie
force-pushed
the
ele-1707-add-source-freshness-as-test-part-2
branch
from
9c4e141 to
7dd11c1
Compare
NoyaArie
force-pushed
the
ele-1707-add-source-freshness-as-test-part-2
branch
from
7dd11c1 to
eab5a2e
Compare
NoyaArie
commented
Nov 5, 2023
| self.connections_manager: Optional[BaseConnectionManager] = None | ||
| self.project_parser: Optional[ManifestLoader] = None | ||
| self.manifest = None | ||
| self.manifest: Optional[Manifest] = None |
Contributor
Author
There was a problem hiding this comment.
not related - CI error fix
NoyaArie
commented
Nov 5, 2023
| ): | ||
| super().__init__(dbt_runner) | ||
| self.tests_fetcher = TestsFetcher(dbt_runner=self.dbt_runner) | ||
| self.invocations_api = InvocationsAPI(dbt_runner) |
erikzaadi
approved these changes
Nov 5, 2023
Contributor
erikzaadi
left a comment
erikzaadi
left a comment
There was a problem hiding this comment.
1 small nit, besides that:
|
|
||
|
|
||
| class SourceFreshnessResultDBRowSchema(ExtendedBaseModel): | ||
| __test__ = False # Mark for pytest - The class name starts with "Test" which throws warnings on pytest runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.