fix file path when uploading to Azure Blob Storage#1423
Merged
Conversation
ellakz
approved these changes
Feb 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Elementary team,
I encountered an issue while sending my report to Azure Blob Storage. I noticed that when providing the argument '--bucket-file-path' Elementary only keeps the filename and gets rid of the folders. For example:
test/elementary/elementary_report.htmlbecomeselementary_report.html.I found out that we were using the
basenamemethod to only keep the base name.I propose this simple modification to keep the full path provided by the user when sending the report to Azure. This issue might also be happening on GCS or S3, I haven't tested it on these platforms.
Thanks
Samir