Skip to content

test description in alerts bug in dbt 1.9 #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofek1weiss merged 2 commits into from
Mar 13, 2025
Merged

test description in alerts bug in dbt 1.9 #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd2d88
test description in alerts bug in dbt 1.9
ofek1weiss Mar 13, 2025
113bc25
Merge branch 'master' into test-description-in-alerts-dbt-19
ofek1weiss Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions elementary/monitor/dbt_project/macros/alerts/population/test_alerts.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
'column_name': raw_test_alert.column_name,
'test_type': test_type,
'test_sub_type': raw_test_alert.sub_type,
'test_description': raw_test_alert.test_description,
'test_results_description': raw_test_alert.alert_description,
'owners': raw_test_alert.owners,
'tags': raw_test_alert.tags,
Expand Down Expand Up @@ -143,6 +144,7 @@
failed_tests.status,
failed_tests.result_rows,
tests.meta as test_meta,
tests.description as test_description,
artifacts_meta.meta as model_meta
from failed_tests
left join tests on failed_tests.test_unique_id = tests.unique_id
Expand Down
3 changes: 2 additions & 1 deletion elementary/monitor/fetchers/alerts/schema/alert_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ class TestAlertDataSchema(BaseAlertDataSchema):
column_name: Optional[str] = None
test_type: str
test_sub_type: str
test_description: Optional[str] = None
test_results_description: Optional[str] = None
test_results_query: Optional[str] = None
test_rows_sample: Optional[List[Dict]] = None
Expand Down Expand Up @@ -203,7 +204,7 @@ def format_alert(
test_results_description=self.test_results_description,
test_results_query=self.test_results_query,
test_short_name=self.test_short_name,
test_description=self.description,
test_description=self.description or self.test_description,
other=self.other,
test_params=self.test_params,
test_rows_sample=self.test_rows_sample if not disable_samples else None,
Expand Down
Loading