-
Notifications
You must be signed in to change notification settings - Fork 204
ignore monitor failure on clickhouse #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflows for testing warehouse integrations were updated to remove the "clickhouse" warehouse type from input choices and test matrices. The Clickhouse service startup step was disabled, and the conditional Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
👋 @michael-myaskovsky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-warehouse.yml (1)
172-173: Standardize workaround comment and track cleanup
Please convert the inline comment into aTODO:with a reference (issue number or date) so it’s clear when and why this workaround should be removed. For example:- # remove this once clickhouse supports anomaly detection + # TODO: remove when ClickHouse anomaly detection is supported (see ISSUE-123)This will help prevent the hack from lingering indefinitely.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-warehouse.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: code-quality
arbiv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove clickhouse from these tests until we add proper support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-all-warehouses.yml (1)
29-31: Removed ClickHouse from the test matrix
The matrix no longer includesclickhouse, which aligns with disabling its service startup elsewhere. Ensure that any ClickHouse–specific handling (e.g.,continue-on-errorbranches or legacy secrets) in the reusabletest-warehouse.ymlworkflow is fully cleaned up now that it’s never invoked.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/test-all-warehouses.yml(1 hunks).github/workflows/test-release.yml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/test-release.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: code-quality
- GitHub Check: test / test
null
Summary by CodeRabbit