Skip to content

Conversation

@michael-myaskovsky
Copy link
Contributor

@michael-myaskovsky michael-myaskovsky commented Jun 16, 2025

null

Summary by CodeRabbit

  • Chores
    • Removed Clickhouse option from warehouse type selection and disabled related services in the workflows.

@coderabbitai
Copy link

coderabbitai bot commented Jun 16, 2025

Walkthrough

The GitHub Actions workflows for testing warehouse integrations were updated to remove the "clickhouse" warehouse type from input choices and test matrices. The Clickhouse service startup step was disabled, and the conditional continue-on-error flag for Clickhouse in the dbt package integration tests was removed.

Changes

File(s) Change Summary
.github/workflows/test-warehouse.yml Removed "clickhouse" from warehouse-type input choices; commented out Clickhouse service startup step; removed conditional continue-on-error for Clickhouse in dbt package integration tests step.
.github/workflows/test-all-warehouses.yml Removed "clickhouse" from warehouse-type matrix in test job.
.github/workflows/test-release.yml Removed "clickhouse" from warehouse-type matrix in validate-upgrade-cli job.

Possibly related PRs

Poem

🐰 Hopping out Clickhouse’s way,
The workflow clears a brighter day.
No more errors to skip or hide,
Just clean runs on every side.
A rabbit’s touch, swift and neat,
Makes CI dance on nimble feet! 🌿


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

👋 @michael-myaskovsky
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/test-warehouse.yml (1)

172-173: Standardize workaround comment and track cleanup
Please convert the inline comment into a TODO: with a reference (issue number or date) so it’s clear when and why this workaround should be removed. For example:

-        # remove this once clickhouse supports anomaly detection
+        # TODO: remove when ClickHouse anomaly detection is supported (see ISSUE-123)

This will help prevent the hack from lingering indefinitely.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b716d0f and fe5768c.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: code-quality

Copy link
Contributor

@arbiv arbiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove clickhouse from these tests until we add proper support

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/test-all-warehouses.yml (1)

29-31: Removed ClickHouse from the test matrix
The matrix no longer includes clickhouse, which aligns with disabling its service startup elsewhere. Ensure that any ClickHouse–specific handling (e.g., continue-on-error branches or legacy secrets) in the reusable test-warehouse.yml workflow is fully cleaned up now that it’s never invoked.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 282bbf0 and 71ab728.

📒 Files selected for processing (2)
  • .github/workflows/test-all-warehouses.yml (1 hunks)
  • .github/workflows/test-release.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/test-release.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: code-quality
  • GitHub Check: test / test

@michael-myaskovsky michael-myaskovsky merged commit 5d65bab into master Jun 16, 2025
5 checks passed
@michael-myaskovsky michael-myaskovsky deleted the ignore-monitor-failure-clickhouse branch June 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants