Skip to content

ci: remove unused GCS_KEYFILE from test-warehouse workflow#2213

Merged
haritamar merged 1 commit into
masterfrom
devin/1777213565-remove-gcs-keyfile
Apr 26, 2026
Merged

ci: remove unused GCS_KEYFILE from test-warehouse workflow#2213
haritamar merged 1 commit into
masterfrom
devin/1777213565-remove-gcs-keyfile

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Apr 26, 2026

Summary

Remove the unused GCS_KEYFILE secret and related GCS references from the test-warehouse.yml workflow.

Changes:

  • Remove the "Write GCS keyfile" step that decoded GCS_KEYFILE to /tmp/gcs_keyfile.json
  • Remove the commented-out --google-service-account-path and --gcs-bucket-name flags from the send-report step

The GCS upload was already disabled (commented out), so this is a cleanup-only change with no functional impact.

Review & Testing Checklist for Human

  • Confirm that GCS report upload is no longer needed for CI

Notes

The GCS_KEYFILE secret reference and the commented-out GCS flags were dead code — the report upload only uses S3 and Azure today.

Link to Devin session: https://app.devin.ai/sessions/3745da6a144342e68d7a35a6f02092ff
Requested by: @haritamar

Summary by CodeRabbit

  • Chores
    • Updated test workflow configuration to streamline report delivery settings by removing unused temporary credentials and parameters.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b5ba1e8a-48b2-487a-a635-ef8666f29923

📥 Commits

Reviewing files that changed from the base of the PR and between 47e9931 and eb808b1.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/test-warehouse.yml

📝 Walkthrough

Walkthrough

The test warehouse workflow removes unused Google Cloud service account keyfile generation from secrets and eliminates two commented-out GCS upload parameters from the report delivery command, streamlining the workflow configuration.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test-warehouse.yml
Removed temporary GCS keyfile generation and two commented-out GCS upload parameters from the edr monitor send-report invocation, keeping only active Slack, AWS, and Azure report delivery arguments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A keyfile unused, now laid to rest,
Comments removed—the workflow's blessed!
GCS cleanup, commented-out lines gone,
Slack and Azure dance on and on! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing an unused GCS_KEYFILE secret from the test-warehouse CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777213565-remove-gcs-keyfile

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit c24a73a into master Apr 26, 2026
10 of 24 checks passed
@haritamar haritamar deleted the devin/1777213565-remove-gcs-keyfile branch April 26, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant