Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-github-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs:
edr monitor
-t snowflake
--slack-token "${{ secrets.CI_SLACK_TOKEN }}"
--slack-channel-name data-ops
--slack-channel-name oss-ci-tests
&&
edr monitor report
-t snowflake
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-warehouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ jobs:
--project-profile-target "${{ inputs.warehouse-type }}"
--slack-file-name "report_${{ inputs.warehouse-type }}_${{ env.BRANCH_NAME }}.html"
--slack-token "$SLACK_TOKEN"
--slack-channel-name data-ops
--slack-channel-name oss-ci-tests
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, let's look at the context around line 395 in the workflow file
cat -n .github/workflows/test-warehouse.yml | sed -n '385,405p'

Repository: elementary-data/elementary

Length of output: 1289


🏁 Script executed:

# Search for references to Slack channels and previous names in the workflow
rg -i "slack.*channel" .github/workflows/test-warehouse.yml -B 2 -A 2

Repository: elementary-data/elementary

Length of output: 404


🏁 Script executed:

# Look for the edr monitor send-report command to understand its usage
rg "edr monitor send-report" -r . -B 3 -A 3

Repository: elementary-data/elementary

Length of output: 52


🏁 Script executed:

# Check if there are any references to channel names in config files or scripts
fd -e yml -e yaml -e json | xargs rg -l "oss-ci-tests\|slack.*channel" 2>/dev/null | head -20

Repository: elementary-data/elementary

Length of output: 52


🏁 Script executed:

# Check git history for this file to see what changed
git log --oneline -n 20 .github/workflows/test-warehouse.yml

Repository: elementary-data/elementary

Length of output: 134


🏁 Script executed:

# Look for specific commit that changed the channel name
git log -p .github/workflows/test-warehouse.yml | grep -i "slack-channel" -B 3 -A 3 | head -30

Repository: elementary-data/elementary

Length of output: 52


🏁 Script executed:

# Search for documentation about Slack channels or setup
fd -e md -e txt | xargs rg -l -i "slack.*channel\|oss-ci" 2>/dev/null

Repository: elementary-data/elementary

Length of output: 54


🏁 Script executed:

# Check if there are any environment variable configurations or secrets setup docs
fd -e md | xargs rg -i "slack.*token\|CI_SLACK" 2>/dev/null | head -20

Repository: elementary-data/elementary

Length of output: 52


🏁 Script executed:

# Get more details about the commit that renamed the channel
git show 37670a4b --stat

Repository: elementary-data/elementary

Length of output: 50382


🏁 Script executed:

# Check if there's a setup guide or CONTRIBUTING guide
fd -e md | xargs rg -l -i "setup\|contrib\|slack" 2>/dev/null

Repository: elementary-data/elementary

Length of output: 54


🏁 Script executed:

# Look in the actual edr source or docs directory for slack validation
find . -type d \( -name "docs" -o -name "doc" -o -name "edr" \) 2>/dev/null | head -10

Repository: elementary-data/elementary

Length of output: 77


🏁 Script executed:

# Check if there are any setup scripts or github actions that validate secrets
rg -i "slack_token\|SLACK_TOKEN" --type sh --type yml 2>/dev/null | head -20

Repository: elementary-data/elementary

Length of output: 52


🏁 Script executed:

# Check the Slack integration documentation
cat docs/_snippets/setup-slack-integration.mdx | head -100

Repository: elementary-data/elementary

Length of output: 3257


🏁 Script executed:

# Search for SLACK_TOKEN or CI_SLACK_TOKEN environment variable definitions
rg "SLACK_TOKEN|CI_SLACK_TOKEN" .github/workflows/ -B 2 -A 2

Repository: elementary-data/elementary

Length of output: 1396


Channel and token are already configured; ensure oss-ci-tests exists and bot has required Slack scopes.

The channel rename from data-ops to oss-ci-tests has already been merged. Verify that the Slack bot (from CI_SLACK_TOKEN) has been:

  • Added to the oss-ci-tests channel
  • Granted these scopes: channels:join, channels:read, chat:write, files:write

If the channel doesn't exist or the bot lacks these scopes, the edr monitor send-report command will fail.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test-warehouse.yml at line 395, The Slack channel name
flag in the workflow uses --slack-channel-name oss-ci-tests for the edr monitor
send-report step but the CI bot may not be in that channel or may lack scopes;
ensure the channel "oss-ci-tests" exists, add the bot tied to CI_SLACK_TOKEN to
that channel, and grant the bot the required Slack scopes channels:join,
channels:read, chat:write, files:write so the edr monitor send-report command
can post successfully.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged — this is a user-requested channel rename. The oss-ci-tests channel existence and bot access will be verified by the team before merging.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

--bucket-file-path "ci_reports/report_${{ inputs.warehouse-type }}_${{ env.BRANCH_NAME }}.html"
--aws-access-key-id "$AWS_ACCESS_KEY_ID"
--aws-secret-access-key "$AWS_SECRET_ACCESS_KEY"
Expand Down
Loading