Conversation
|
👋 @IDoneShaveIt |
…ags-and-owners-sidebars
…ags-and-owners-sidebars
…ags-and-owners-sidebars
…ags-and-owners-sidebars
| test_tuns_totals: Dict[str, TotalsSchema], | ||
| models: Dict[str, NormalizedModelSchema], | ||
| sources: Dict[str, NormalizedSourceSchema], | ||
| models_runs: List[ModelRunsSchema], | ||
| ) -> FiltersSchema: | ||
| test_results_filters = self._get_test_filters( | ||
| test_results_totals, models, sources | ||
| ) | ||
| test_runs_filters = self._get_test_filters(test_tuns_totals, models, sources) |
There was a problem hiding this comment.
| test_tuns_totals: Dict[str, TotalsSchema], | |
| models: Dict[str, NormalizedModelSchema], | |
| sources: Dict[str, NormalizedSourceSchema], | |
| models_runs: List[ModelRunsSchema], | |
| ) -> FiltersSchema: | |
| test_results_filters = self._get_test_filters( | |
| test_results_totals, models, sources | |
| ) | |
| test_runs_filters = self._get_test_filters(test_tuns_totals, models, sources) | |
| test_runs_totals: Dict[str, TotalsSchema], | |
| models: Dict[str, NormalizedModelSchema], | |
| sources: Dict[str, NormalizedSourceSchema], | |
| models_runs: List[ModelRunsSchema], | |
| ) -> FiltersSchema: | |
| test_results_filters = self._get_test_filters( | |
| test_results_totals, models, sources | |
| ) | |
| test_runs_filters = self._get_test_filters(test_runs_totals, models, sources) |
| and not total.errors | ||
| and not total.passed | ||
| ): | ||
| no_tests_filter.add_model_unique_id(model_unique_id) |
There was a problem hiding this comment.
Can this happen? or just for safety?
(e.g. can totals contain a key that doesn't have tests?)
There was a problem hiding this comment.
Yes :)
You can define models without tests / run dbt test -s which will cause only partial tests to run.
On both cases we can have a situation where there are no tests 🙂
|
|
||
|
|
||
| class InvocationSchema(BaseModel): | ||
| affected_rows: Optional[int] |
There was a problem hiding this comment.
Why do we need both TotalsInvocationsSchema and TotalsSchema?
There was a problem hiding this comment.
Well they used to be different and I somehow like that we define a schema for each data type (even if they are the same).
But I agree that currently its a bit redundant
2 participants
Added 2 more sidebars to the report - tags & owners.