Skip to content

Fix breaking changes in dbt 1.4.0#566

Merged
elongl merged 2 commits intomasterfrom
ele-160-fix-breaking-changes-in-dbt-140
Jan 15, 2023
Merged

Fix breaking changes in dbt 1.4.0#566
elongl merged 2 commits intomasterfrom
ele-160-fix-breaking-changes-in-dbt-140

Conversation

@elongl
Copy link
Contributor

@elongl elongl commented Jan 15, 2023

No description provided.

@linear
Copy link

linear bot commented Jan 15, 2023

ELE-160 Fix breaking changes in dbt 1.4.0

Here are some of the issues that we know of, could be more.

  1. dbt changed the merge_sql macro that we use to merge data_monitoring_metrics in the on-run-end. It accepts another parameter that we also need to accept on our own merge_sql macro.

  2. dbt changed the format of the JSON when using --log-format json.

    They renamed a property from data to info which makes the edr doesn't work because all run-operations return empty lists.

@github-actions
Copy link
Contributor

👋 @elongl
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@elongl elongl changed the title Applied compatibility to new format on '--log-format json'. Fix breaking changes in dbt 1.4.0 Jan 15, 2023
@elongl elongl merged commit c9fa372 into master Jan 15, 2023
@elongl elongl deleted the ele-160-fix-breaking-changes-in-dbt-140 branch January 15, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants