Skip to content

Ele 327 create report endpoint#665

Merged
IDoneShaveIt merged 29 commits into
masterfrom
ele-327-create-report-endpoint
Feb 16, 2023
Merged

Ele 327 create report endpoint#665
IDoneShaveIt merged 29 commits into
masterfrom
ele-327-create-report-endpoint

Conversation

@IDoneShaveIt
Copy link
Copy Markdown
Contributor

@IDoneShaveIt IDoneShaveIt commented Feb 12, 2023

Created an endpoint for report generating via webapp API.

  • Split APIs into APIs and fetchers.
  • Moved API logic from data monitoring report to report API.
  • No new logic - only renaming and moving files around

@linear
Copy link
Copy Markdown

linear Bot commented Feb 12, 2023

ELE-327 Create report endpoint

DoD:

  • This endpoint should return the same json as the one we inject today to the html
  • Endpoint should not run CLIs, therefore we should make it fast enough by:
    • Running the edr code as python code and not the CLI
    • Running dbt-core with python instead of running a sub-process (PythonDbtRunner)

@github-actions
Copy link
Copy Markdown
Contributor

👋 @IDoneShaveIt
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@IDoneShaveIt IDoneShaveIt merged commit 2ea4044 into master Feb 16, 2023
@IDoneShaveIt IDoneShaveIt deleted the ele-327-create-report-endpoint branch February 16, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant