Skip to content

change macro names#672

Merged
Maayan-s merged 1 commit into
masterfrom
ele-375-collision-of-macro-names
Feb 14, 2023
Merged

change macro names#672
Maayan-s merged 1 commit into
masterfrom
ele-375-collision-of-macro-names

Conversation

@Maayan-s
Copy link
Copy Markdown
Collaborator

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 14, 2023

ELE-375 Collision of macro names with other packages prevents using Elementary

Describe the bug
When deploying Elementary with other dbt packages, naming collisions cause dbt to fail.
This does not happen if the package creators ref macros explicitly, but we can't count on it.
We found this with dbt-expectations and reported, the new version fixes it but is only relevant to dbt +1.3.0.

Additional context
Slack thread - https://elementary-community.slack.com/archives/C02CTC89LAX/p1676049955315149

@github-actions
Copy link
Copy Markdown
Contributor

👋 @Maayan-s
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@Maayan-s Maayan-s merged commit ba0660d into master Feb 14, 2023
@Maayan-s Maayan-s deleted the ele-375-collision-of-macro-names branch February 14, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ELE-375] Collision of macro names with other packages prevents using Elementary

1 participant