fix alerts filter#679
Merged
Merged
Conversation
Contributor
|
👋 @IDoneShaveIt |
RoiTabach
reviewed
Feb 15, 2023
Comment on lines
+41
to
+44
| elif filter.selector: | ||
| logger.error( | ||
| f"An unsupported alerts selector has been provided - {filter.selector}!\nNo alert has been sent!" | ||
| ) |
Contributor
There was a problem hiding this comment.
I think desired behaviour in case of an invalid selector is "don't filter and just send all alerts forward", not "filter everything out"
RoiTabach
reviewed
Feb 15, 2023
| assert len(filter_model_alerts) == len(model_alerts) | ||
| assert len(filter_malformed_alerts) == len(malformed_alerts) | ||
|
|
||
| # Test that filter with unsupported selector returns no alert |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.