Skip to content

Ele 352 - Report performance#700

Merged
IDoneShaveIt merged 7 commits into
masterfrom
report-performance
Feb 23, 2023
Merged

Ele 352 - Report performance#700
IDoneShaveIt merged 7 commits into
masterfrom
report-performance

Conversation

@IDoneShaveIt
Copy link
Copy Markdown
Contributor

  • Created SlimDbtRunner that currently only support run_operation method
  • Changed all the macros to return values instead of log them
  • Added a mechanism should_log to DbtRunner that wraps the run_operation with the a macro that edr_log that logs the given macro results (It set to True by default and keeps the same behaviour as before the change)

@github-actions
Copy link
Copy Markdown
Contributor

👋 @IDoneShaveIt
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Comment thread elementary/clients/api/api_client.py Outdated
Comment thread elementary/clients/dbt/slim_dbt_runner.py
Comment thread elementary/clients/fetcher/fetcher.py Outdated
@IDoneShaveIt IDoneShaveIt merged commit b628147 into master Feb 23, 2023
@IDoneShaveIt IDoneShaveIt deleted the report-performance branch February 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants