Skip to content

ELE-393 support bucket-website-url cli param#716

Merged
IDoneShaveIt merged 6 commits into
masterfrom
ele-393-set-gcs-url-as-a-parameter-instead
Feb 28, 2023
Merged

ELE-393 support bucket-website-url cli param#716
IDoneShaveIt merged 6 commits into
masterfrom
ele-393-set-gcs-url-as-a-parameter-instead

Conversation

@IDoneShaveIt
Copy link
Copy Markdown
Contributor

No description provided.

@IDoneShaveIt IDoneShaveIt requested a review from elongl February 27, 2023 15:19
@linear
Copy link
Copy Markdown

linear Bot commented Feb 27, 2023

ELE-393 Set GCS url as a parameter instead

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

bucket_website_url = f"https://storage.googleapis.com/{full_bucket_path}"

Some GCS cloud storage is using this url http://storage.cloud.google.com instead to host the html reports
Can we allow users to configure this on their end?

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Would you be willing to contribute this feature?
Let us know if you're willing to contribute so that we'll be able to provide guidance.

@github-actions
Copy link
Copy Markdown
Contributor

👋 @IDoneShaveIt
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Comment thread elementary/clients/gcs/client.py Outdated
Comment thread elementary/clients/s3/client.py
@IDoneShaveIt IDoneShaveIt merged commit 1c53fb7 into master Feb 28, 2023
@IDoneShaveIt IDoneShaveIt deleted the ele-393-set-gcs-url-as-a-parameter-instead branch February 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants