Skip to content

config: don't do the dbt debug check if git is not installed#720

Merged
haritamar merged 3 commits into
masterfrom
ele-444-not-require-git-for-edr-docker-image-to
Feb 28, 2023
Merged

config: don't do the dbt debug check if git is not installed#720
haritamar merged 3 commits into
masterfrom
ele-444-not-require-git-for-edr-docker-image-to

Conversation

@haritamar
Copy link
Copy Markdown
Collaborator

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 28, 2023

ELE-444 Not require `git` for `edr` docker image to work.

Is your feature request related to a problem? Please describe.
Currently, upon edr's initialization, we run dbt debug.
We do this mostly to ensure that the elementary profile is available and set up correctly.
dbt supports reading the profiles.yml from either the working directory or ~/.dbt/profiles.yml,
so this is a way of handing the responsibility to them rather than re-implement the following logic.

The main problem is that dbt debug requires git to be installed and otherwise it fails which raises an exception at edr.
And in practice, not everyone has git installed.

Describe the solution you'd like

  1. Either remove the call for dbt debug and search for profiles.yml and add a validation that it's set up correctly.
  2. Keep it and only log it.
  3. Other options.

Additional context
Slack threads:

  1. https://elementary-community.slack.com/archives/C02CTC89LAX/p1677471254515409
  2. https://elementary-community.slack.com/archives/C02CTC89LAX/p1677571371399949

@github-actions
Copy link
Copy Markdown
Contributor

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@elongl elongl linked an issue Feb 28, 2023 that may be closed by this pull request
@haritamar haritamar merged commit 9c63341 into master Feb 28, 2023
@haritamar haritamar deleted the ele-444-not-require-git-for-edr-docker-image-to branch February 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ELE-444] Not require git for edr docker image to work.

2 participants